mstorsjo wrote: > > Minor nit, we could adjust the commit message (PR description), saying > > "even if that may be dllimported", instead of "is dllimported". If it has > > an explicit dllimport, iirc this issue doesn't hit at all - it's the "maybe > > dllimported" case which is problematic here. > > Updated. I hope I have written precisely.
Thanks! I took the liberty to further reword it a bit more, to clarify the scope - let me know if you disagree with the wording. https://github.com/llvm/llvm-project/pull/150938 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits