[llvm-branch-commits] [flang] [mlir] [flang][OpenACC] generate Destroy region to free memory of private and firstprivate if needed (PR #162702)

[Razvan Lupusoru via llvm-branch-commits]

================
@@ -53,12 +53,15 @@ struct OpenACCMappableModel
   mlir::acc::VariableTypeCategory getTypeCategory(mlir::Type type,
                                                   mlir::Value var) const;
 
+  bool generatePrivateDestroy(mlir::Type type, mlir::OpBuilder &builder,
----------------
razvanlupusoru wrote:

nit: Please swap the declaration order with generatePrivateInit - looks "off" 
to me to have destroy first.

https://github.com/llvm/llvm-project/pull/162702
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits