mingmingl-llvm wrote: > > The change looks fine but should there be a test that uses the DAP profiles > > and triggers this? > > Yeah removing validation without test coverage is generally a 'meh' PR indeed > :( > > This piece of code doesn't have test coverage in the trunk-of-tree. > [95292a6](https://github.com/llvm/llvm-project/commit/95292a62e7dbd09aecd3bf24b8a6c90cdd1dceda) > adds a RUN line (`not llc`). I'll rebase this PR on top of that one to show > the updated test.
Sorry for being back and forth. I realized I need a new `llc` test which process IR with section_prefix eventually. Let me add that as a new test (under `CodeGen`) in the prior PR https://github.com/llvm/llvm-project/pull/162348 which tests `not llc`. After that * This PR can flip the `not` --> llc should pass * The subsequent PRs of this one can extend on the new test. I'll ping on https://github.com/llvm/llvm-project/pull/162348 and this one when they are ready for review. https://github.com/llvm/llvm-project/pull/162349 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
