mingmingl-llvm wrote: > The change looks fine but should there be a test that uses the DAP profiles > and triggers this?
Yeah removing validation without test coverage is generally a 'meh' PR indeed :( This piece of code doesn't have test coverage in the trunk-of-tree. https://github.com/llvm/llvm-project/pull/162348/commits/95292a62e7dbd09aecd3bf24b8a6c90cdd1dceda adds a RUN line (`not llc`). I'll rebase this PR on top of that one to show the updated test. https://github.com/llvm/llvm-project/pull/162349 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
