mstorsjo wrote:

> The test on main intends to stash all files in that temporary directory (it 
> fails to, see #164396 for that fix), but regardless, it creates the directory.

As mentioned on the other review, I'm not sure if I'd read that much into it - 
and I think this kinda distracts from the core issue here; the old test 
produces a file named `%t`, while the new form on main creates `%` as a temp 
directory.

The change looks good to me though.

https://github.com/llvm/llvm-project/pull/164384
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to