DavidSpickett wrote: > As mentioned on the other review, I'm not sure if I'd read that much into it > - and I think this kinda distracts from the core issue here
I put that in for context to explain why the tree shown does not match what you (or at least I) would assume that test was doing. You're right that the point is it makes a directory, but, one might see the weird layout and say well why not fix it on main then. Which we are doing as well. Idk, borderline but it's the kind of detail I will appreciate if this comes back up again in future. That said, I deal with random test failures all day, so I may have weird tastes there. https://github.com/llvm/llvm-project/pull/164384 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
