================ @@ -3802,6 +3808,22 @@ OPT_LIST(V) StringRef getCUIDHash() const; + void findPFPFields(QualType Ty, CharUnits Offset, ---------------- ojhunt wrote:
I think this should be cached, it's used in hasPFPFields which sounds like a trivial check but currently really isn't. I'm not super fond of the inclusion of the offset, as this information should be the same for a given type regardless of offset, it feels like the caller side should be responsible for ensuring the correct offsets are applied. Certainly if the offset is part of the look up it neutralizes a lot of the cache benefit. https://github.com/llvm/llvm-project/pull/172119 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
