================
@@ -9791,7 +9791,14 @@ unsigned SIInstrInfo::getInstSizeInBytes(const
MachineInstr &MI) const {
LiteralSize = 8;
break;
case AMDGPU::OPERAND_REG_IMM_INT64:
- if (!Op.isImm() || !AMDGPU::isValid32BitLiteral(Op.getImm(),
false))
+ // A 32-bit literal is only valid when the value fits in BOTH
signed
+ // and unsigned 32-bit ranges [0, 2^31-1], matching the MC code
+ // emitter's getLit64Encoding logic. This is because of the lack of
+ // abilility to tell signedness of the literal, therefore we need
to
----------------
shiltian wrote:
Agreed. Like @jayfoad mentioned in the original PR, this can be reverted once
we have signedness, which is beyond the scope of this PR. At this moment this
causes build failure in downstream build, so we need to fix it first and then
improve it.
https://github.com/llvm/llvm-project/pull/180387
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
