https://github.com/kiranchandramohan commented:
Thanks @skatrak for taking the effort to clean up and unify the integration tests. Apologies that you ran into issues with the review. The intent behind including the note in each integration test is to encourage anyone adding a test to first consider whether the same coverage can be achieved without running all the compiler stages, and to use an integration test only when necessary. I agree that duplicating the note is not ideal. The current approach deliberately errs on the side of discouraging integration tests unless they are necessary. This follows the general LLVM testing practice of avoiding tests that exercise compiler stages unrelated to the functionality being tested. Doing so also helps avoid placing a maintenance burden on the wider LLVM community, where changes in LLVM could otherwise require updates to Flang integration tests. If there is another way to provide the same reminder when a test is added, or if integration tests are no more a concern for llvm, or if everyone feels that duplicating the message is not serving the purpose then we can consider switching. https://github.com/llvm/llvm-project/pull/215536 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
