https://github.com/Sukumarsawant updated https://github.com/llvm/llvm-project/pull/217390
>From 8e89764f255dd50ae49955b31ceb4abf344698b0 Mon Sep 17 00:00:00 2001 From: Sukumarsawant <[email protected]> Date: Wed, 19 Aug 2026 22:09:51 +0530 Subject: [PATCH 1/3] fmaximumf128 --- libc/config/baremetal/aarch64/entrypoints.txt | 2 +- libc/config/baremetal/arm/entrypoints.txt | 2 +- libc/config/baremetal/riscv/entrypoints.txt | 2 +- libc/config/darwin/aarch64/entrypoints.txt | 2 +- libc/config/darwin/x86_64/entrypoints.txt | 1 + libc/config/freebsd/x86_64/entrypoints.txt | 2 +- libc/config/gpu/amdgpu/entrypoints.txt | 1 + libc/config/gpu/nvptx/entrypoints.txt | 1 + libc/config/linux/aarch64/entrypoints.txt | 2 +- libc/config/linux/arm/entrypoints.txt | 1 + libc/config/linux/riscv/entrypoints.txt | 2 +- libc/config/linux/x86_64/entrypoints.txt | 2 +- libc/config/windows/entrypoints.txt | 1 + libc/shared/math/fmaximumf128.h | 6 ------ libc/src/__support/math/CMakeLists.txt | 2 +- libc/src/__support/math/fmaximumf128.h | 11 ++++------- libc/src/math/fmaximumf128.h | 5 +++++ libc/src/math/generic/CMakeLists.txt | 1 + libc/src/math/generic/fmaximumf128.cpp | 6 +++++- libc/test/shared/shared_math_constexpr_test.cpp | 6 +++--- libc/test/shared/shared_math_test.cpp | 6 +++--- libc/test/src/math/smoke/CMakeLists.txt | 1 + libc/test/src/math/smoke/fmaximumf128_test.cpp | 5 +++++ utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++- .../libc/test/src/math/smoke/BUILD.bazel | 3 +++ 25 files changed, 47 insertions(+), 30 deletions(-) diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt index e7dce9a59c3d3..2b72b28357e1b 100644 --- a/libc/config/baremetal/aarch64/entrypoints.txt +++ b/libc/config/baremetal/aarch64/entrypoints.txt @@ -434,6 +434,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -756,7 +757,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt index 67ca6750e65f7..2321fa2b103eb 100644 --- a/libc/config/baremetal/arm/entrypoints.txt +++ b/libc/config/baremetal/arm/entrypoints.txt @@ -446,6 +446,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -767,7 +768,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt index d38ad6e1c2232..98360e0ed2752 100644 --- a/libc/config/baremetal/riscv/entrypoints.txt +++ b/libc/config/baremetal/riscv/entrypoints.txt @@ -442,6 +442,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -764,7 +765,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt index b346b2a131a9a..4a0f169a2c645 100644 --- a/libc/config/darwin/aarch64/entrypoints.txt +++ b/libc/config/darwin/aarch64/entrypoints.txt @@ -253,6 +253,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -576,7 +577,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt index 52ee843d106c3..2951652bca248 100644 --- a/libc/config/darwin/x86_64/entrypoints.txt +++ b/libc/config/darwin/x86_64/entrypoints.txt @@ -158,6 +158,7 @@ set(TARGET_LIBM_ENTRYPOINTS #libc.src.math.fmax #libc.src.math.fmaxf #libc.src.math.fmaxf128 + #libc.src.math.fmaximumf128 #libc.src.math.fmaxl #libc.src.math.fmin #libc.src.math.fminf diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt index c51949b135c12..3e7f54c381aed 100644 --- a/libc/config/freebsd/x86_64/entrypoints.txt +++ b/libc/config/freebsd/x86_64/entrypoints.txt @@ -183,6 +183,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaxl libc.src.math.fmaximum libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaximum_num libc.src.math.fmaximum_numf @@ -515,7 +516,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt index 1b68b9fdaa75c..9454732d24280 100644 --- a/libc/config/gpu/amdgpu/entrypoints.txt +++ b/libc/config/gpu/amdgpu/entrypoints.txt @@ -372,6 +372,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaxf128 libc.src.math.fmaximum libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaximum_mag libc.src.math.fmaximum_magf diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt index 2d372c34047c1..f682572b36cb1 100644 --- a/libc/config/gpu/nvptx/entrypoints.txt +++ b/libc/config/gpu/nvptx/entrypoints.txt @@ -368,6 +368,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaxf128 libc.src.math.fmaximum libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaximum_mag libc.src.math.fmaximum_magf diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt index 8c41024e3904f..42ee54a526266 100644 --- a/libc/config/linux/aarch64/entrypoints.txt +++ b/libc/config/linux/aarch64/entrypoints.txt @@ -593,6 +593,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -909,7 +910,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt index c4fa17986e9a7..aeec26824281b 100644 --- a/libc/config/linux/arm/entrypoints.txt +++ b/libc/config/linux/arm/entrypoints.txt @@ -421,6 +421,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt index 2d311be11f5f4..0283e098abab3 100644 --- a/libc/config/linux/riscv/entrypoints.txt +++ b/libc/config/linux/riscv/entrypoints.txt @@ -661,6 +661,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -994,7 +995,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt index f8a6e4ac016d0..56343f6555e20 100644 --- a/libc/config/linux/x86_64/entrypoints.txt +++ b/libc/config/linux/x86_64/entrypoints.txt @@ -671,6 +671,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -1004,7 +1005,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt index c3efab38cd60c..06a86851b40e8 100644 --- a/libc/config/windows/entrypoints.txt +++ b/libc/config/windows/entrypoints.txt @@ -216,6 +216,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaxl libc.src.math.fmaximum libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaximum_num libc.src.math.fmaximum_numf diff --git a/libc/shared/math/fmaximumf128.h b/libc/shared/math/fmaximumf128.h index 12b53d74e4f7e..af6beefbb99fb 100644 --- a/libc/shared/math/fmaximumf128.h +++ b/libc/shared/math/fmaximumf128.h @@ -9,10 +9,6 @@ #ifndef LLVM_LIBC_SHARED_MATH_FMAXIMUMF128_H #define LLVM_LIBC_SHARED_MATH_FMAXIMUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "shared/libc_common.h" #include "src/__support/math/fmaximumf128.h" @@ -24,6 +20,4 @@ using math::fmaximumf128; } // namespace shared } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SHARED_MATH_FMAXIMUMF128_H diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt index 9ec3f8eb3242e..063393080fb88 100644 --- a/libc/src/__support/math/CMakeLists.txt +++ b/libc/src/__support/math/CMakeLists.txt @@ -899,7 +899,7 @@ add_header_library( HDRS fmaximumf128.h DEPENDS - libc.include.llvm-libc-types.float128 + libc.src.__support.FPUtil.float128 libc.src.__support.FPUtil.basic_operations libc.src.__support.macros.config ) diff --git a/libc/src/__support/math/fmaximumf128.h b/libc/src/__support/math/fmaximumf128.h index 136b16419cd58..91326ef27887f 100644 --- a/libc/src/__support/math/fmaximumf128.h +++ b/libc/src/__support/math/fmaximumf128.h @@ -9,23 +9,20 @@ #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUMF128_H #define LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "src/__support/FPUtil/BasicOperations.h" +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" namespace LIBC_NAMESPACE_DECL { namespace math { -LIBC_INLINE constexpr float128 fmaximumf128(float128 x, float128 y) { +using LIBC_NAMESPACE::fputil::Float128; + +LIBC_INLINE constexpr Float128 fmaximumf128(Float128 x, Float128 y) { return fputil::fmaximum(x, y); } } // namespace math } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUMF128_H diff --git a/libc/src/math/fmaximumf128.h b/libc/src/math/fmaximumf128.h index 3cc6fa023c797..5eb3451448047 100644 --- a/libc/src/math/fmaximumf128.h +++ b/libc/src/math/fmaximumf128.h @@ -10,11 +10,16 @@ #ifndef LLVM_LIBC_SRC_MATH_FMAXIMUMF128_H #define LLVM_LIBC_SRC_MATH_FMAXIMUMF128_H +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" #include "src/__support/macros/properties/types.h" namespace LIBC_NAMESPACE_DECL { +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + float128 fmaximumf128(float128 x, float128 y); } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt index 46265a187ecd1..3e5ec1bb905bf 100644 --- a/libc/src/math/generic/CMakeLists.txt +++ b/libc/src/math/generic/CMakeLists.txt @@ -2166,6 +2166,7 @@ add_entrypoint_object( HDRS ../fmaximumf128.h DEPENDS + libc.src.__support.CPP.bit libc.src.__support.math.fmaximumf128 ) diff --git a/libc/src/math/generic/fmaximumf128.cpp b/libc/src/math/generic/fmaximumf128.cpp index 88b698c19ccea..889cdbf4c35dc 100644 --- a/libc/src/math/generic/fmaximumf128.cpp +++ b/libc/src/math/generic/fmaximumf128.cpp @@ -7,12 +7,16 @@ //===----------------------------------------------------------------------===// #include "src/math/fmaximumf128.h" +#include "src/__support/CPP/bit.h" #include "src/__support/math/fmaximumf128.h" namespace LIBC_NAMESPACE_DECL { +using LIBC_NAMESPACE::fputil::Float128; + LLVM_LIBC_FUNCTION(float128, fmaximumf128, (float128 x, float128 y)) { - return math::fmaximumf128(x, y); + return cpp::bit_cast<float128>(math::fmaximumf128( + cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y))); } } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp index c02683eff896f..1595136ac12b1 100644 --- a/libc/test/shared/shared_math_constexpr_test.cpp +++ b/libc/test/shared/shared_math_constexpr_test.cpp @@ -381,6 +381,9 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L)); //===----------------------------------------------------------------------===// static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0))); +static_assert(Float128(0.0) == + LIBC_NAMESPACE::shared::fmaximumf128(Float128(0.0), + Float128(0.0))); static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::copysignf128(Float128(0.0), Float128(0.0))); @@ -420,9 +423,6 @@ static_assert(float128(1.0) == LIBC_NAMESPACE::shared::fdimf128(float128(1.0), float128(0.0))); static_assert(0.0f == LIBC_NAMESPACE::shared::fdivf128(float128(0.0), float128(1.0))); -static_assert(float128(0.0) == - LIBC_NAMESPACE::shared::fmaximumf128(float128(0.0), - float128(0.0))); static_assert(float128(0.0) == LIBC_NAMESPACE::shared::fminimumf128(float128(0.0), float128(0.0))); diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp index ca0a4e6dda816..37065155ba637 100644 --- a/libc/test/shared/shared_math_test.cpp +++ b/libc/test/shared/shared_math_test.cpp @@ -584,6 +584,9 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) { EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0))); + + EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fmaximumf128( + Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::copysignf128( Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fabsf128(Float128(0.0))); @@ -693,9 +696,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) { 0.0f16, LIBC_NAMESPACE::shared::f16subf128(float128(0.0), float128(0.0))); EXPECT_FP_EQ(0.0f16, LIBC_NAMESPACE::shared::f16sqrtf128(float128(0.0))); #endif // LIBC_TYPES_HAS_FLOAT16 - - EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fmaximumf128( - float128(0.0), float128(0.0))); EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimumf128( float128(0.0), float128(0.0))); EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128( diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt index ea3518233a5e5..dfc4c22cba130 100644 --- a/libc/test/src/math/smoke/CMakeLists.txt +++ b/libc/test/src/math/smoke/CMakeLists.txt @@ -2857,6 +2857,7 @@ add_fp_unittest( HDRS FMaximumTest.h DEPENDS + libc.src.__support.FPUtil.float128 libc.src.math.fmaximumf128 libc.src.__support.CPP.algorithm libc.src.__support.FPUtil.fp_bits diff --git a/libc/test/src/math/smoke/fmaximumf128_test.cpp b/libc/test/src/math/smoke/fmaximumf128_test.cpp index 7e0b97bcdd4de..3d8a00842df6d 100644 --- a/libc/test/src/math/smoke/fmaximumf128_test.cpp +++ b/libc/test/src/math/smoke/fmaximumf128_test.cpp @@ -7,7 +7,12 @@ //===----------------------------------------------------------------------===// #include "FMaximumTest.h" +#include "src/__support/FPUtil/float128.h" #include "src/math/fmaximumf128.h" +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + LIST_FMAXIMUM_TESTS(float128, LIBC_NAMESPACE::fmaximumf128) diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel index 15fbc4b594e1d..b6459fe8075b4 100644 --- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel @@ -5453,8 +5453,8 @@ libc_support_library( hdrs = ["src/__support/math/fmaximumf128.h"], deps = [ ":__support_fputil_basic_operations", + ":__support_fputil_float128", ":__support_macros_config", - ":llvm_libc_types_float128", ], ) @@ -11830,6 +11830,8 @@ libc_math_function( libc_math_function( name = "fmaximumf128", additional_deps = [ + ":__support_cpp_bit", + ":__support_fputil_float128", ":__support_math_fmaximumf128", ], ) diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel index ae3d27283c086..8ccbede554d7a 100644 --- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel @@ -566,6 +566,9 @@ math_test( math_test( name = "fmaximumf128", hdrs = ["FMaximumTest.h"], + deps = [ + "//libc:__support_fputil_float128", + ], ) math_test( >From 2a798d4369907b576639ee1b744a7f7d84fb1977 Mon Sep 17 00:00:00 2001 From: Sukumarsawant <[email protected]> Date: Wed, 19 Aug 2026 22:14:00 +0530 Subject: [PATCH 2/3] fminimumf128 --- libc/config/baremetal/aarch64/entrypoints.txt | 2 +- libc/config/baremetal/arm/entrypoints.txt | 2 +- libc/config/baremetal/riscv/entrypoints.txt | 2 +- libc/config/darwin/aarch64/entrypoints.txt | 2 +- libc/config/darwin/x86_64/entrypoints.txt | 1 + libc/config/freebsd/x86_64/entrypoints.txt | 2 +- libc/config/gpu/amdgpu/entrypoints.txt | 1 + libc/config/gpu/nvptx/entrypoints.txt | 1 + libc/config/linux/aarch64/entrypoints.txt | 2 +- libc/config/linux/arm/entrypoints.txt | 1 + libc/config/linux/riscv/entrypoints.txt | 2 +- libc/config/linux/x86_64/entrypoints.txt | 2 +- libc/config/windows/entrypoints.txt | 1 + libc/shared/math/fminimumf128.h | 6 ------ libc/src/__support/math/CMakeLists.txt | 2 +- libc/src/__support/math/fminimumf128.h | 11 ++++------- libc/src/math/fminimumf128.h | 5 +++++ libc/src/math/generic/CMakeLists.txt | 1 + libc/src/math/generic/fminimumf128.cpp | 6 +++++- libc/test/shared/shared_math_constexpr_test.cpp | 12 ++++++------ libc/test/shared/shared_math_test.cpp | 9 ++++----- libc/test/src/math/smoke/CMakeLists.txt | 1 + libc/test/src/math/smoke/fminimumf128_test.cpp | 5 +++++ utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++- .../libc/test/src/math/smoke/BUILD.bazel | 3 +++ 25 files changed, 51 insertions(+), 35 deletions(-) diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt index 2b72b28357e1b..9b2438dca9a38 100644 --- a/libc/config/baremetal/aarch64/entrypoints.txt +++ b/libc/config/baremetal/aarch64/entrypoints.txt @@ -451,6 +451,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -760,7 +761,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt index 2321fa2b103eb..e2d288d1f790d 100644 --- a/libc/config/baremetal/arm/entrypoints.txt +++ b/libc/config/baremetal/arm/entrypoints.txt @@ -463,6 +463,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -771,7 +772,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt index 98360e0ed2752..9b359785f994c 100644 --- a/libc/config/baremetal/riscv/entrypoints.txt +++ b/libc/config/baremetal/riscv/entrypoints.txt @@ -459,6 +459,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -768,7 +769,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 # libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt index 4a0f169a2c645..cd88c643912c0 100644 --- a/libc/config/darwin/aarch64/entrypoints.txt +++ b/libc/config/darwin/aarch64/entrypoints.txt @@ -270,6 +270,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -580,7 +581,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt index 2951652bca248..55eed1c456f08 100644 --- a/libc/config/darwin/x86_64/entrypoints.txt +++ b/libc/config/darwin/x86_64/entrypoints.txt @@ -163,6 +163,7 @@ set(TARGET_LIBM_ENTRYPOINTS #libc.src.math.fmin #libc.src.math.fminf #libc.src.math.fminf128 + #libc.src.math.fminimumf128 #libc.src.math.fminl #libc.src.math.fmod #libc.src.math.fmodf diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt index 3e7f54c381aed..fdf6b17103e35 100644 --- a/libc/config/freebsd/x86_64/entrypoints.txt +++ b/libc/config/freebsd/x86_64/entrypoints.txt @@ -196,6 +196,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_mag_numl libc.src.math.fminimum libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminimum_num libc.src.math.fminimum_numf @@ -519,7 +520,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt index 9454732d24280..63eceda56c7b1 100644 --- a/libc/config/gpu/amdgpu/entrypoints.txt +++ b/libc/config/gpu/amdgpu/entrypoints.txt @@ -389,6 +389,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminf128 libc.src.math.fminimum libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminimum_mag libc.src.math.fminimum_magf diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt index f682572b36cb1..8122738f1711f 100644 --- a/libc/config/gpu/nvptx/entrypoints.txt +++ b/libc/config/gpu/nvptx/entrypoints.txt @@ -385,6 +385,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminf128 libc.src.math.fminimum libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminimum_mag libc.src.math.fminimum_magf diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt index 42ee54a526266..7cce5ac0ea908 100644 --- a/libc/config/linux/aarch64/entrypoints.txt +++ b/libc/config/linux/aarch64/entrypoints.txt @@ -610,6 +610,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -913,7 +914,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt index aeec26824281b..5adabaac76fbf 100644 --- a/libc/config/linux/arm/entrypoints.txt +++ b/libc/config/linux/arm/entrypoints.txt @@ -438,6 +438,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt index 0283e098abab3..6f3df6cadae37 100644 --- a/libc/config/linux/riscv/entrypoints.txt +++ b/libc/config/linux/riscv/entrypoints.txt @@ -678,6 +678,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -998,7 +999,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt index 56343f6555e20..8101d65fa9880 100644 --- a/libc/config/linux/x86_64/entrypoints.txt +++ b/libc/config/linux/x86_64/entrypoints.txt @@ -688,6 +688,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -1008,7 +1009,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt index 06a86851b40e8..a56ede9effa36 100644 --- a/libc/config/windows/entrypoints.txt +++ b/libc/config/windows/entrypoints.txt @@ -229,6 +229,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_mag_numl libc.src.math.fminimum libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminimum_num libc.src.math.fminimum_numf diff --git a/libc/shared/math/fminimumf128.h b/libc/shared/math/fminimumf128.h index 1f31c05d73c15..2604222a7e74f 100644 --- a/libc/shared/math/fminimumf128.h +++ b/libc/shared/math/fminimumf128.h @@ -9,10 +9,6 @@ #ifndef LLVM_LIBC_SHARED_MATH_FMINIMUMF128_H #define LLVM_LIBC_SHARED_MATH_FMINIMUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "shared/libc_common.h" #include "src/__support/math/fminimumf128.h" @@ -24,6 +20,4 @@ using math::fminimumf128; } // namespace shared } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SHARED_MATH_FMINIMUMF128_H diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt index 063393080fb88..355009a146654 100644 --- a/libc/src/__support/math/CMakeLists.txt +++ b/libc/src/__support/math/CMakeLists.txt @@ -1175,7 +1175,7 @@ add_header_library( HDRS fminimumf128.h DEPENDS - libc.include.llvm-libc-types.float128 + libc.src.__support.FPUtil.float128 libc.src.__support.FPUtil.basic_operations libc.src.__support.macros.config ) diff --git a/libc/src/__support/math/fminimumf128.h b/libc/src/__support/math/fminimumf128.h index cfbe36ba1fb81..6a6ed675ffa27 100644 --- a/libc/src/__support/math/fminimumf128.h +++ b/libc/src/__support/math/fminimumf128.h @@ -9,23 +9,20 @@ #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUMF128_H #define LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "src/__support/FPUtil/BasicOperations.h" +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" namespace LIBC_NAMESPACE_DECL { namespace math { -LIBC_INLINE constexpr float128 fminimumf128(float128 x, float128 y) { +using LIBC_NAMESPACE::fputil::Float128; + +LIBC_INLINE constexpr Float128 fminimumf128(Float128 x, Float128 y) { return fputil::fminimum(x, y); } } // namespace math } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUMF128_H diff --git a/libc/src/math/fminimumf128.h b/libc/src/math/fminimumf128.h index d507766059909..18c5d4d8c1672 100644 --- a/libc/src/math/fminimumf128.h +++ b/libc/src/math/fminimumf128.h @@ -10,11 +10,16 @@ #ifndef LLVM_LIBC_SRC_MATH_FMINIMUMF128_H #define LLVM_LIBC_SRC_MATH_FMINIMUMF128_H +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" #include "src/__support/macros/properties/types.h" namespace LIBC_NAMESPACE_DECL { +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + float128 fminimumf128(float128 x, float128 y); } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt index 3e5ec1bb905bf..b9dfebbc23009 100644 --- a/libc/src/math/generic/CMakeLists.txt +++ b/libc/src/math/generic/CMakeLists.txt @@ -2407,6 +2407,7 @@ add_entrypoint_object( HDRS ../fminimumf128.h DEPENDS + libc.src.__support.CPP.bit libc.src.__support.math.fminimumf128 ) diff --git a/libc/src/math/generic/fminimumf128.cpp b/libc/src/math/generic/fminimumf128.cpp index b8fb50f0d424c..77c8504d49519 100644 --- a/libc/src/math/generic/fminimumf128.cpp +++ b/libc/src/math/generic/fminimumf128.cpp @@ -7,12 +7,16 @@ //===----------------------------------------------------------------------===// #include "src/math/fminimumf128.h" +#include "src/__support/CPP/bit.h" #include "src/__support/math/fminimumf128.h" namespace LIBC_NAMESPACE_DECL { +using LIBC_NAMESPACE::fputil::Float128; + LLVM_LIBC_FUNCTION(float128, fminimumf128, (float128 x, float128 y)) { - return math::fminimumf128(x, y); + return cpp::bit_cast<float128>(math::fminimumf128( + cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y))); } } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp index 1595136ac12b1..1297f5b7839fe 100644 --- a/libc/test/shared/shared_math_constexpr_test.cpp +++ b/libc/test/shared/shared_math_constexpr_test.cpp @@ -381,9 +381,6 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L)); //===----------------------------------------------------------------------===// static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0))); -static_assert(Float128(0.0) == - LIBC_NAMESPACE::shared::fmaximumf128(Float128(0.0), - Float128(0.0))); static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::copysignf128(Float128(0.0), Float128(0.0))); @@ -395,6 +392,12 @@ static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::fmaxf128(Float128(0.0), Float128(0.0))); static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::fminf128(Float128(0.0), Float128(0.0))); +static_assert(Float128(0.0) == + LIBC_NAMESPACE::shared::fmaximumf128(Float128(0.0), + Float128(0.0))); +static_assert(Float128(0.0) == + LIBC_NAMESPACE::shared::fminimumf128(Float128(0.0), + Float128(0.0))); static_assert(0LL == LIBC_NAMESPACE::shared::llroundf128(Float128(0.0))); static_assert(0L == LIBC_NAMESPACE::shared::lroundf128(Float128(0.0))); static_assert(Float128(0.0) == @@ -423,9 +426,6 @@ static_assert(float128(1.0) == LIBC_NAMESPACE::shared::fdimf128(float128(1.0), float128(0.0))); static_assert(0.0f == LIBC_NAMESPACE::shared::fdivf128(float128(0.0), float128(1.0))); -static_assert(float128(0.0) == - LIBC_NAMESPACE::shared::fminimumf128(float128(0.0), - float128(0.0))); static_assert(0.0 == LIBC_NAMESPACE::shared::dsqrtf128(float128(0.0))); static_assert(float128(0.0) == LIBC_NAMESPACE::shared::fmaximum_numf128(float128(0.0), diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp index 37065155ba637..98daf8399ca36 100644 --- a/libc/test/shared/shared_math_test.cpp +++ b/libc/test/shared/shared_math_test.cpp @@ -584,9 +584,6 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) { EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0))); - - EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fmaximumf128( - Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::copysignf128( Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fabsf128(Float128(0.0))); @@ -595,6 +592,10 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) { LIBC_NAMESPACE::shared::fmaxf128(Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminf128(Float128(0.0), Float128(0.0))); + EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fmaximumf128( + Float128(0.0), Float128(0.0))); + EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminimumf128( + Float128(0.0), Float128(0.0))); EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llroundf128(Float128(0.0))); EXPECT_EQ(0L, LIBC_NAMESPACE::shared::lroundf128(Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), @@ -696,8 +697,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) { 0.0f16, LIBC_NAMESPACE::shared::f16subf128(float128(0.0), float128(0.0))); EXPECT_FP_EQ(0.0f16, LIBC_NAMESPACE::shared::f16sqrtf128(float128(0.0))); #endif // LIBC_TYPES_HAS_FLOAT16 - EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimumf128( - float128(0.0), float128(0.0))); EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128( float128(0.0), float128(0.0))); EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128( diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt index dfc4c22cba130..d97a7396c20b7 100644 --- a/libc/test/src/math/smoke/CMakeLists.txt +++ b/libc/test/src/math/smoke/CMakeLists.txt @@ -3203,6 +3203,7 @@ add_fp_unittest( HDRS FMinimumTest.h DEPENDS + libc.src.__support.FPUtil.float128 libc.src.math.fminimumf128 libc.src.__support.CPP.algorithm libc.src.__support.FPUtil.fp_bits diff --git a/libc/test/src/math/smoke/fminimumf128_test.cpp b/libc/test/src/math/smoke/fminimumf128_test.cpp index 163090b8a9ec5..ae585f15beffc 100644 --- a/libc/test/src/math/smoke/fminimumf128_test.cpp +++ b/libc/test/src/math/smoke/fminimumf128_test.cpp @@ -7,7 +7,12 @@ //===----------------------------------------------------------------------===// #include "FMinimumTest.h" +#include "src/__support/FPUtil/float128.h" #include "src/math/fminimumf128.h" +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + LIST_FMINIMUM_TESTS(float128, LIBC_NAMESPACE::fminimumf128) diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel index b6459fe8075b4..8410fa4ab57f3 100644 --- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel @@ -5701,8 +5701,8 @@ libc_support_library( hdrs = ["src/__support/math/fminimumf128.h"], deps = [ ":__support_fputil_basic_operations", + ":__support_fputil_float128", ":__support_macros_config", - ":llvm_libc_types_float128", ], ) @@ -12016,6 +12016,8 @@ libc_math_function( libc_math_function( name = "fminimumf128", additional_deps = [ + ":__support_cpp_bit", + ":__support_fputil_float128", ":__support_math_fminimumf128", ], ) diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel index 8ccbede554d7a..b1fec19379f21 100644 --- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel @@ -697,6 +697,9 @@ math_test( math_test( name = "fminimumf128", hdrs = ["FMinimumTest.h"], + deps = [ + "//libc:__support_fputil_float128", + ], ) math_test( >From 51825830fb1dc336e284800e8e83f3dc626ed623 Mon Sep 17 00:00:00 2001 From: Sukumarsawant <[email protected]> Date: Wed, 19 Aug 2026 22:50:11 +0530 Subject: [PATCH 3/3] nit:cast --- libc/test/src/math/smoke/FMaximumTest.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libc/test/src/math/smoke/FMaximumTest.h b/libc/test/src/math/smoke/FMaximumTest.h index a839eb02b25d8..d7efcd0869a86 100644 --- a/libc/test/src/math/smoke/FMaximumTest.h +++ b/libc/test/src/math/smoke/FMaximumTest.h @@ -68,7 +68,7 @@ class FMaximumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest { continue; T x = xbits.get_val(); T y = ybits.get_val(); - if ((x == 0) && (y == 0)) + if ((x == T(0)) && (y == T(0))) continue; if (x > y) _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
