https://github.com/Sukumarsawant updated https://github.com/llvm/llvm-project/pull/217390
>From c65b4a7ec2f0fb1869b863c68b939c1524e4d9b2 Mon Sep 17 00:00:00 2001 From: Sukumarsawant <[email protected]> Date: Wed, 19 Aug 2026 22:09:51 +0530 Subject: [PATCH 1/4] fmaximumf128 --- libc/config/baremetal/aarch64/entrypoints.txt | 2 +- libc/config/baremetal/arm/entrypoints.txt | 2 +- libc/config/baremetal/riscv/entrypoints.txt | 2 +- libc/config/darwin/aarch64/entrypoints.txt | 2 +- libc/config/darwin/x86_64/entrypoints.txt | 1 + libc/config/freebsd/x86_64/entrypoints.txt | 2 +- libc/config/gpu/amdgpu/entrypoints.txt | 1 + libc/config/gpu/nvptx/entrypoints.txt | 1 + libc/config/linux/aarch64/entrypoints.txt | 2 +- libc/config/linux/arm/entrypoints.txt | 1 + libc/config/linux/riscv/entrypoints.txt | 2 +- libc/config/linux/x86_64/entrypoints.txt | 2 +- libc/config/windows/entrypoints.txt | 1 + libc/shared/math/fmaximumf128.h | 6 ------ libc/src/__support/math/CMakeLists.txt | 2 +- libc/src/__support/math/fmaximumf128.h | 11 ++++------- libc/src/math/fmaximumf128.h | 5 +++++ libc/src/math/generic/CMakeLists.txt | 1 + libc/src/math/generic/fmaximumf128.cpp | 6 +++++- libc/test/shared/shared_math_constexpr_test.cpp | 6 +++--- libc/test/shared/shared_math_test.cpp | 6 +++--- libc/test/src/math/smoke/CMakeLists.txt | 1 + libc/test/src/math/smoke/fmaximumf128_test.cpp | 5 +++++ utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++- .../libc/test/src/math/smoke/BUILD.bazel | 3 +++ 25 files changed, 47 insertions(+), 30 deletions(-) diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt index 948b1f951a0ff..dd68a395e27e4 100644 --- a/libc/config/baremetal/aarch64/entrypoints.txt +++ b/libc/config/baremetal/aarch64/entrypoints.txt @@ -434,6 +434,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -761,7 +762,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt index 586fd0cc8c559..796f8708ede19 100644 --- a/libc/config/baremetal/arm/entrypoints.txt +++ b/libc/config/baremetal/arm/entrypoints.txt @@ -446,6 +446,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -772,7 +773,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt index b588845bb9966..e5484f1443307 100644 --- a/libc/config/baremetal/riscv/entrypoints.txt +++ b/libc/config/baremetal/riscv/entrypoints.txt @@ -442,6 +442,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -769,7 +770,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt index cbefabc5e5b46..6e11e4ea20b1d 100644 --- a/libc/config/darwin/aarch64/entrypoints.txt +++ b/libc/config/darwin/aarch64/entrypoints.txt @@ -253,6 +253,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -581,7 +582,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt index 2ce5a057c4e9b..08aa3195541e1 100644 --- a/libc/config/darwin/x86_64/entrypoints.txt +++ b/libc/config/darwin/x86_64/entrypoints.txt @@ -158,6 +158,7 @@ set(TARGET_LIBM_ENTRYPOINTS #libc.src.math.fmax #libc.src.math.fmaxf #libc.src.math.fmaxf128 + #libc.src.math.fmaximumf128 #libc.src.math.fmaxl #libc.src.math.fmin #libc.src.math.fminf diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt index 954e152d0fc33..1c46145210e02 100644 --- a/libc/config/freebsd/x86_64/entrypoints.txt +++ b/libc/config/freebsd/x86_64/entrypoints.txt @@ -183,6 +183,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaxl libc.src.math.fmaximum libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaximum_num libc.src.math.fmaximum_numf @@ -520,7 +521,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt index 266ca3bd75da9..707d0a15ebb9c 100644 --- a/libc/config/gpu/amdgpu/entrypoints.txt +++ b/libc/config/gpu/amdgpu/entrypoints.txt @@ -372,6 +372,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaxf128 libc.src.math.fmaximum libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaximum_mag libc.src.math.fmaximum_magf diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt index 099cbfb3ddc8e..e3aa79614488d 100644 --- a/libc/config/gpu/nvptx/entrypoints.txt +++ b/libc/config/gpu/nvptx/entrypoints.txt @@ -368,6 +368,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaxf128 libc.src.math.fmaximum libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaximum_mag libc.src.math.fmaximum_magf diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt index d8e46ea3a9f75..3a2b06c71ec3b 100644 --- a/libc/config/linux/aarch64/entrypoints.txt +++ b/libc/config/linux/aarch64/entrypoints.txt @@ -594,6 +594,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -915,7 +916,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt index 4e915aa46ed4a..e2f32531d025c 100644 --- a/libc/config/linux/arm/entrypoints.txt +++ b/libc/config/linux/arm/entrypoints.txt @@ -421,6 +421,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt index f7b88095dc6c0..ed7cbaffc69f2 100644 --- a/libc/config/linux/riscv/entrypoints.txt +++ b/libc/config/linux/riscv/entrypoints.txt @@ -662,6 +662,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -1000,7 +1001,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt index 022f1a8825d60..33640b0125807 100644 --- a/libc/config/linux/x86_64/entrypoints.txt +++ b/libc/config/linux/x86_64/entrypoints.txt @@ -672,6 +672,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_numf libc.src.math.fmaximum_numl libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaxl libc.src.math.fmin @@ -1010,7 +1011,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 libc.src.math.fmaximum_numf128 - libc.src.math.fmaximumf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt index 28a239c68a6f9..c8153baf2bec7 100644 --- a/libc/config/windows/entrypoints.txt +++ b/libc/config/windows/entrypoints.txt @@ -216,6 +216,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaxl libc.src.math.fmaximum libc.src.math.fmaximumf + libc.src.math.fmaximumf128 libc.src.math.fmaximuml libc.src.math.fmaximum_num libc.src.math.fmaximum_numf diff --git a/libc/shared/math/fmaximumf128.h b/libc/shared/math/fmaximumf128.h index 12b53d74e4f7e..af6beefbb99fb 100644 --- a/libc/shared/math/fmaximumf128.h +++ b/libc/shared/math/fmaximumf128.h @@ -9,10 +9,6 @@ #ifndef LLVM_LIBC_SHARED_MATH_FMAXIMUMF128_H #define LLVM_LIBC_SHARED_MATH_FMAXIMUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "shared/libc_common.h" #include "src/__support/math/fmaximumf128.h" @@ -24,6 +20,4 @@ using math::fmaximumf128; } // namespace shared } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SHARED_MATH_FMAXIMUMF128_H diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt index 92123e0bd81f9..3b1454eba92ec 100644 --- a/libc/src/__support/math/CMakeLists.txt +++ b/libc/src/__support/math/CMakeLists.txt @@ -899,7 +899,7 @@ add_header_library( HDRS fmaximumf128.h DEPENDS - libc.include.llvm-libc-types.float128 + libc.src.__support.FPUtil.float128 libc.src.__support.FPUtil.basic_operations libc.src.__support.macros.config ) diff --git a/libc/src/__support/math/fmaximumf128.h b/libc/src/__support/math/fmaximumf128.h index 136b16419cd58..91326ef27887f 100644 --- a/libc/src/__support/math/fmaximumf128.h +++ b/libc/src/__support/math/fmaximumf128.h @@ -9,23 +9,20 @@ #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUMF128_H #define LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "src/__support/FPUtil/BasicOperations.h" +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" namespace LIBC_NAMESPACE_DECL { namespace math { -LIBC_INLINE constexpr float128 fmaximumf128(float128 x, float128 y) { +using LIBC_NAMESPACE::fputil::Float128; + +LIBC_INLINE constexpr Float128 fmaximumf128(Float128 x, Float128 y) { return fputil::fmaximum(x, y); } } // namespace math } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUMF128_H diff --git a/libc/src/math/fmaximumf128.h b/libc/src/math/fmaximumf128.h index 3cc6fa023c797..5eb3451448047 100644 --- a/libc/src/math/fmaximumf128.h +++ b/libc/src/math/fmaximumf128.h @@ -10,11 +10,16 @@ #ifndef LLVM_LIBC_SRC_MATH_FMAXIMUMF128_H #define LLVM_LIBC_SRC_MATH_FMAXIMUMF128_H +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" #include "src/__support/macros/properties/types.h" namespace LIBC_NAMESPACE_DECL { +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + float128 fmaximumf128(float128 x, float128 y); } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt index b4534e4c10621..270e43bd0db25 100644 --- a/libc/src/math/generic/CMakeLists.txt +++ b/libc/src/math/generic/CMakeLists.txt @@ -2171,6 +2171,7 @@ add_entrypoint_object( HDRS ../fmaximumf128.h DEPENDS + libc.src.__support.CPP.bit libc.src.__support.math.fmaximumf128 ) diff --git a/libc/src/math/generic/fmaximumf128.cpp b/libc/src/math/generic/fmaximumf128.cpp index 88b698c19ccea..889cdbf4c35dc 100644 --- a/libc/src/math/generic/fmaximumf128.cpp +++ b/libc/src/math/generic/fmaximumf128.cpp @@ -7,12 +7,16 @@ //===----------------------------------------------------------------------===// #include "src/math/fmaximumf128.h" +#include "src/__support/CPP/bit.h" #include "src/__support/math/fmaximumf128.h" namespace LIBC_NAMESPACE_DECL { +using LIBC_NAMESPACE::fputil::Float128; + LLVM_LIBC_FUNCTION(float128, fmaximumf128, (float128 x, float128 y)) { - return math::fmaximumf128(x, y); + return cpp::bit_cast<float128>(math::fmaximumf128( + cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y))); } } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp index 797509965a139..4e0cf14b9e0c4 100644 --- a/libc/test/shared/shared_math_constexpr_test.cpp +++ b/libc/test/shared/shared_math_constexpr_test.cpp @@ -381,6 +381,9 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L)); //===----------------------------------------------------------------------===// static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0))); +static_assert(Float128(0.0) == + LIBC_NAMESPACE::shared::fmaximumf128(Float128(0.0), + Float128(0.0))); static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::copysignf128(Float128(0.0), Float128(0.0))); @@ -427,9 +430,6 @@ static_assert(float128(1.0) == LIBC_NAMESPACE::shared::fdimf128(float128(1.0), float128(0.0))); static_assert(0.0f == LIBC_NAMESPACE::shared::fdivf128(float128(0.0), float128(1.0))); -static_assert(float128(0.0) == - LIBC_NAMESPACE::shared::fmaximumf128(float128(0.0), - float128(0.0))); static_assert(float128(0.0) == LIBC_NAMESPACE::shared::fminimumf128(float128(0.0), float128(0.0))); diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp index 8dc2b9d36831c..df7ca52fdbe14 100644 --- a/libc/test/shared/shared_math_test.cpp +++ b/libc/test/shared/shared_math_test.cpp @@ -584,6 +584,9 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) { EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0))); + + EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fmaximumf128( + Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::copysignf128( Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fabsf128(Float128(0.0))); @@ -699,9 +702,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) { 0.0f16, LIBC_NAMESPACE::shared::f16subf128(float128(0.0), float128(0.0))); EXPECT_FP_EQ(0.0f16, LIBC_NAMESPACE::shared::f16sqrtf128(float128(0.0))); #endif // LIBC_TYPES_HAS_FLOAT16 - - EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fmaximumf128( - float128(0.0), float128(0.0))); EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimumf128( float128(0.0), float128(0.0))); EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128( diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt index 355534f00a585..83fb0367f99e2 100644 --- a/libc/test/src/math/smoke/CMakeLists.txt +++ b/libc/test/src/math/smoke/CMakeLists.txt @@ -2862,6 +2862,7 @@ add_fp_unittest( HDRS FMaximumTest.h DEPENDS + libc.src.__support.FPUtil.float128 libc.src.math.fmaximumf128 libc.src.__support.CPP.algorithm libc.src.__support.FPUtil.fp_bits diff --git a/libc/test/src/math/smoke/fmaximumf128_test.cpp b/libc/test/src/math/smoke/fmaximumf128_test.cpp index 7e0b97bcdd4de..3d8a00842df6d 100644 --- a/libc/test/src/math/smoke/fmaximumf128_test.cpp +++ b/libc/test/src/math/smoke/fmaximumf128_test.cpp @@ -7,7 +7,12 @@ //===----------------------------------------------------------------------===// #include "FMaximumTest.h" +#include "src/__support/FPUtil/float128.h" #include "src/math/fmaximumf128.h" +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + LIST_FMAXIMUM_TESTS(float128, LIBC_NAMESPACE::fmaximumf128) diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel index 7f0b8f8251226..2fbb04a4fd358 100644 --- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel @@ -5453,8 +5453,8 @@ libc_support_library( hdrs = ["src/__support/math/fmaximumf128.h"], deps = [ ":__support_fputil_basic_operations", + ":__support_fputil_float128", ":__support_macros_config", - ":llvm_libc_types_float128", ], ) @@ -11830,6 +11830,8 @@ libc_math_function( libc_math_function( name = "fmaximumf128", additional_deps = [ + ":__support_cpp_bit", + ":__support_fputil_float128", ":__support_math_fmaximumf128", ], ) diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel index 50f5594824551..f4a882d85b1ee 100644 --- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel @@ -566,6 +566,9 @@ math_test( math_test( name = "fmaximumf128", hdrs = ["FMaximumTest.h"], + deps = [ + "//libc:__support_fputil_float128", + ], ) math_test( >From 822c54779f1fe1d510412b9de42cbc9f0799c490 Mon Sep 17 00:00:00 2001 From: Sukumarsawant <[email protected]> Date: Wed, 19 Aug 2026 22:14:00 +0530 Subject: [PATCH 2/4] fminimumf128 --- libc/config/baremetal/aarch64/entrypoints.txt | 2 +- libc/config/baremetal/arm/entrypoints.txt | 2 +- libc/config/baremetal/riscv/entrypoints.txt | 2 +- libc/config/darwin/aarch64/entrypoints.txt | 2 +- libc/config/darwin/x86_64/entrypoints.txt | 1 + libc/config/freebsd/x86_64/entrypoints.txt | 2 +- libc/config/gpu/amdgpu/entrypoints.txt | 1 + libc/config/gpu/nvptx/entrypoints.txt | 1 + libc/config/linux/aarch64/entrypoints.txt | 2 +- libc/config/linux/arm/entrypoints.txt | 1 + libc/config/linux/riscv/entrypoints.txt | 2 +- libc/config/linux/x86_64/entrypoints.txt | 2 +- libc/config/windows/entrypoints.txt | 1 + libc/shared/math/fminimumf128.h | 6 ------ libc/src/__support/math/CMakeLists.txt | 2 +- libc/src/__support/math/fminimumf128.h | 11 ++++------- libc/src/math/fminimumf128.h | 5 +++++ libc/src/math/generic/CMakeLists.txt | 1 + libc/src/math/generic/fminimumf128.cpp | 6 +++++- libc/test/shared/shared_math_constexpr_test.cpp | 12 ++++++------ libc/test/shared/shared_math_test.cpp | 9 ++++----- libc/test/src/math/smoke/CMakeLists.txt | 1 + libc/test/src/math/smoke/fminimumf128_test.cpp | 5 +++++ utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++- .../libc/test/src/math/smoke/BUILD.bazel | 3 +++ 25 files changed, 51 insertions(+), 35 deletions(-) diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt index dd68a395e27e4..aff61e99ac684 100644 --- a/libc/config/baremetal/aarch64/entrypoints.txt +++ b/libc/config/baremetal/aarch64/entrypoints.txt @@ -451,6 +451,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -765,7 +766,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt index 796f8708ede19..cacedc40866e4 100644 --- a/libc/config/baremetal/arm/entrypoints.txt +++ b/libc/config/baremetal/arm/entrypoints.txt @@ -463,6 +463,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -776,7 +777,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt index e5484f1443307..8a7b5a329e4e1 100644 --- a/libc/config/baremetal/riscv/entrypoints.txt +++ b/libc/config/baremetal/riscv/entrypoints.txt @@ -459,6 +459,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -773,7 +774,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 # libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt index 6e11e4ea20b1d..96f310e4fc05d 100644 --- a/libc/config/darwin/aarch64/entrypoints.txt +++ b/libc/config/darwin/aarch64/entrypoints.txt @@ -270,6 +270,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -585,7 +586,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt index 08aa3195541e1..a7760b2b6ef40 100644 --- a/libc/config/darwin/x86_64/entrypoints.txt +++ b/libc/config/darwin/x86_64/entrypoints.txt @@ -163,6 +163,7 @@ set(TARGET_LIBM_ENTRYPOINTS #libc.src.math.fmin #libc.src.math.fminf #libc.src.math.fminf128 + #libc.src.math.fminimumf128 #libc.src.math.fminl #libc.src.math.fmod #libc.src.math.fmodf diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt index 1c46145210e02..165d4ca33b5d2 100644 --- a/libc/config/freebsd/x86_64/entrypoints.txt +++ b/libc/config/freebsd/x86_64/entrypoints.txt @@ -196,6 +196,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_mag_numl libc.src.math.fminimum libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminimum_num libc.src.math.fminimum_numf @@ -524,7 +525,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt index 707d0a15ebb9c..3ce678b24996a 100644 --- a/libc/config/gpu/amdgpu/entrypoints.txt +++ b/libc/config/gpu/amdgpu/entrypoints.txt @@ -389,6 +389,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminf128 libc.src.math.fminimum libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminimum_mag libc.src.math.fminimum_magf diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt index e3aa79614488d..9a4dd8560c9f3 100644 --- a/libc/config/gpu/nvptx/entrypoints.txt +++ b/libc/config/gpu/nvptx/entrypoints.txt @@ -385,6 +385,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminf128 libc.src.math.fminimum libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminimum_mag libc.src.math.fminimum_magf diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt index 3a2b06c71ec3b..461ce848af8ae 100644 --- a/libc/config/linux/aarch64/entrypoints.txt +++ b/libc/config/linux/aarch64/entrypoints.txt @@ -611,6 +611,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -919,7 +920,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt index e2f32531d025c..7fde0e4a7b1cd 100644 --- a/libc/config/linux/arm/entrypoints.txt +++ b/libc/config/linux/arm/entrypoints.txt @@ -438,6 +438,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt index ed7cbaffc69f2..372a3052bb542 100644 --- a/libc/config/linux/riscv/entrypoints.txt +++ b/libc/config/linux/riscv/entrypoints.txt @@ -679,6 +679,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -1004,7 +1005,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt index 33640b0125807..1e9cd4cfdac0d 100644 --- a/libc/config/linux/x86_64/entrypoints.txt +++ b/libc/config/linux/x86_64/entrypoints.txt @@ -689,6 +689,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_numf libc.src.math.fminimum_numl libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminl libc.src.math.fmod @@ -1014,7 +1015,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 - libc.src.math.fminimumf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt index c8153baf2bec7..568bd2d5ccb2b 100644 --- a/libc/config/windows/entrypoints.txt +++ b/libc/config/windows/entrypoints.txt @@ -229,6 +229,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_mag_numl libc.src.math.fminimum libc.src.math.fminimumf + libc.src.math.fminimumf128 libc.src.math.fminimuml libc.src.math.fminimum_num libc.src.math.fminimum_numf diff --git a/libc/shared/math/fminimumf128.h b/libc/shared/math/fminimumf128.h index 1f31c05d73c15..2604222a7e74f 100644 --- a/libc/shared/math/fminimumf128.h +++ b/libc/shared/math/fminimumf128.h @@ -9,10 +9,6 @@ #ifndef LLVM_LIBC_SHARED_MATH_FMINIMUMF128_H #define LLVM_LIBC_SHARED_MATH_FMINIMUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "shared/libc_common.h" #include "src/__support/math/fminimumf128.h" @@ -24,6 +20,4 @@ using math::fminimumf128; } // namespace shared } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SHARED_MATH_FMINIMUMF128_H diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt index 3b1454eba92ec..bee27901ea822 100644 --- a/libc/src/__support/math/CMakeLists.txt +++ b/libc/src/__support/math/CMakeLists.txt @@ -1175,7 +1175,7 @@ add_header_library( HDRS fminimumf128.h DEPENDS - libc.include.llvm-libc-types.float128 + libc.src.__support.FPUtil.float128 libc.src.__support.FPUtil.basic_operations libc.src.__support.macros.config ) diff --git a/libc/src/__support/math/fminimumf128.h b/libc/src/__support/math/fminimumf128.h index cfbe36ba1fb81..6a6ed675ffa27 100644 --- a/libc/src/__support/math/fminimumf128.h +++ b/libc/src/__support/math/fminimumf128.h @@ -9,23 +9,20 @@ #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUMF128_H #define LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "src/__support/FPUtil/BasicOperations.h" +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" namespace LIBC_NAMESPACE_DECL { namespace math { -LIBC_INLINE constexpr float128 fminimumf128(float128 x, float128 y) { +using LIBC_NAMESPACE::fputil::Float128; + +LIBC_INLINE constexpr Float128 fminimumf128(Float128 x, Float128 y) { return fputil::fminimum(x, y); } } // namespace math } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUMF128_H diff --git a/libc/src/math/fminimumf128.h b/libc/src/math/fminimumf128.h index d507766059909..18c5d4d8c1672 100644 --- a/libc/src/math/fminimumf128.h +++ b/libc/src/math/fminimumf128.h @@ -10,11 +10,16 @@ #ifndef LLVM_LIBC_SRC_MATH_FMINIMUMF128_H #define LLVM_LIBC_SRC_MATH_FMINIMUMF128_H +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" #include "src/__support/macros/properties/types.h" namespace LIBC_NAMESPACE_DECL { +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + float128 fminimumf128(float128 x, float128 y); } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt index 270e43bd0db25..c1c70f2aba6c6 100644 --- a/libc/src/math/generic/CMakeLists.txt +++ b/libc/src/math/generic/CMakeLists.txt @@ -2412,6 +2412,7 @@ add_entrypoint_object( HDRS ../fminimumf128.h DEPENDS + libc.src.__support.CPP.bit libc.src.__support.math.fminimumf128 ) diff --git a/libc/src/math/generic/fminimumf128.cpp b/libc/src/math/generic/fminimumf128.cpp index b8fb50f0d424c..77c8504d49519 100644 --- a/libc/src/math/generic/fminimumf128.cpp +++ b/libc/src/math/generic/fminimumf128.cpp @@ -7,12 +7,16 @@ //===----------------------------------------------------------------------===// #include "src/math/fminimumf128.h" +#include "src/__support/CPP/bit.h" #include "src/__support/math/fminimumf128.h" namespace LIBC_NAMESPACE_DECL { +using LIBC_NAMESPACE::fputil::Float128; + LLVM_LIBC_FUNCTION(float128, fminimumf128, (float128 x, float128 y)) { - return math::fminimumf128(x, y); + return cpp::bit_cast<float128>(math::fminimumf128( + cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y))); } } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp index 4e0cf14b9e0c4..42554fcff1f51 100644 --- a/libc/test/shared/shared_math_constexpr_test.cpp +++ b/libc/test/shared/shared_math_constexpr_test.cpp @@ -381,9 +381,6 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L)); //===----------------------------------------------------------------------===// static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0))); -static_assert(Float128(0.0) == - LIBC_NAMESPACE::shared::fmaximumf128(Float128(0.0), - Float128(0.0))); static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::copysignf128(Float128(0.0), Float128(0.0))); @@ -395,6 +392,12 @@ static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::fmaxf128(Float128(0.0), Float128(0.0))); static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::fminf128(Float128(0.0), Float128(0.0))); +static_assert(Float128(0.0) == + LIBC_NAMESPACE::shared::fmaximumf128(Float128(0.0), + Float128(0.0))); +static_assert(Float128(0.0) == + LIBC_NAMESPACE::shared::fminimumf128(Float128(0.0), + Float128(0.0))); static_assert(0LL == LIBC_NAMESPACE::shared::llrintf128(Float128(0.0))); static_assert(0LL == LIBC_NAMESPACE::shared::llroundf128(Float128(0.0))); static_assert(0L == LIBC_NAMESPACE::shared::lrintf128(Float128(0.0))); @@ -430,9 +433,6 @@ static_assert(float128(1.0) == LIBC_NAMESPACE::shared::fdimf128(float128(1.0), float128(0.0))); static_assert(0.0f == LIBC_NAMESPACE::shared::fdivf128(float128(0.0), float128(1.0))); -static_assert(float128(0.0) == - LIBC_NAMESPACE::shared::fminimumf128(float128(0.0), - float128(0.0))); static_assert(0.0 == LIBC_NAMESPACE::shared::dsqrtf128(float128(0.0))); static_assert(float128(0.0) == LIBC_NAMESPACE::shared::fmaximum_numf128(float128(0.0), diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp index df7ca52fdbe14..6ac5d1a8bf2be 100644 --- a/libc/test/shared/shared_math_test.cpp +++ b/libc/test/shared/shared_math_test.cpp @@ -584,9 +584,6 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) { EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0))); - - EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fmaximumf128( - Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::copysignf128( Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fabsf128(Float128(0.0))); @@ -595,6 +592,10 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) { LIBC_NAMESPACE::shared::fmaxf128(Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminf128(Float128(0.0), Float128(0.0))); + EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fmaximumf128( + Float128(0.0), Float128(0.0))); + EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminimumf128( + Float128(0.0), Float128(0.0))); EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llrintf128(Float128(0.0))); EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llroundf128(Float128(0.0))); EXPECT_EQ(0L, LIBC_NAMESPACE::shared::lrintf128(Float128(0.0))); @@ -702,8 +703,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) { 0.0f16, LIBC_NAMESPACE::shared::f16subf128(float128(0.0), float128(0.0))); EXPECT_FP_EQ(0.0f16, LIBC_NAMESPACE::shared::f16sqrtf128(float128(0.0))); #endif // LIBC_TYPES_HAS_FLOAT16 - EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimumf128( - float128(0.0), float128(0.0))); EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128( float128(0.0), float128(0.0))); EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128( diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt index 83fb0367f99e2..7ea511c2b0a7e 100644 --- a/libc/test/src/math/smoke/CMakeLists.txt +++ b/libc/test/src/math/smoke/CMakeLists.txt @@ -3208,6 +3208,7 @@ add_fp_unittest( HDRS FMinimumTest.h DEPENDS + libc.src.__support.FPUtil.float128 libc.src.math.fminimumf128 libc.src.__support.CPP.algorithm libc.src.__support.FPUtil.fp_bits diff --git a/libc/test/src/math/smoke/fminimumf128_test.cpp b/libc/test/src/math/smoke/fminimumf128_test.cpp index 163090b8a9ec5..ae585f15beffc 100644 --- a/libc/test/src/math/smoke/fminimumf128_test.cpp +++ b/libc/test/src/math/smoke/fminimumf128_test.cpp @@ -7,7 +7,12 @@ //===----------------------------------------------------------------------===// #include "FMinimumTest.h" +#include "src/__support/FPUtil/float128.h" #include "src/math/fminimumf128.h" +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + LIST_FMINIMUM_TESTS(float128, LIBC_NAMESPACE::fminimumf128) diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel index 2fbb04a4fd358..77b5554c3b1cd 100644 --- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel @@ -5701,8 +5701,8 @@ libc_support_library( hdrs = ["src/__support/math/fminimumf128.h"], deps = [ ":__support_fputil_basic_operations", + ":__support_fputil_float128", ":__support_macros_config", - ":llvm_libc_types_float128", ], ) @@ -12016,6 +12016,8 @@ libc_math_function( libc_math_function( name = "fminimumf128", additional_deps = [ + ":__support_cpp_bit", + ":__support_fputil_float128", ":__support_math_fminimumf128", ], ) diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel index f4a882d85b1ee..0b6e6fddcd722 100644 --- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel @@ -697,6 +697,9 @@ math_test( math_test( name = "fminimumf128", hdrs = ["FMinimumTest.h"], + deps = [ + "//libc:__support_fputil_float128", + ], ) math_test( >From 2ba80c5aed4869bafc41332fdb537af5aea82049 Mon Sep 17 00:00:00 2001 From: Sukumarsawant <[email protected]> Date: Wed, 19 Aug 2026 22:50:11 +0530 Subject: [PATCH 3/4] nit:cast --- libc/test/src/math/smoke/FMaximumTest.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libc/test/src/math/smoke/FMaximumTest.h b/libc/test/src/math/smoke/FMaximumTest.h index a839eb02b25d8..d7efcd0869a86 100644 --- a/libc/test/src/math/smoke/FMaximumTest.h +++ b/libc/test/src/math/smoke/FMaximumTest.h @@ -68,7 +68,7 @@ class FMaximumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest { continue; T x = xbits.get_val(); T y = ybits.get_val(); - if ((x == 0) && (y == 0)) + if ((x == T(0)) && (y == T(0))) continue; if (x > y) >From f7226f62b5a0e780272829415cc1e8cb6f8ba367 Mon Sep 17 00:00:00 2001 From: Sukumarsawant <[email protected]> Date: Wed, 19 Aug 2026 23:07:00 +0530 Subject: [PATCH 4/4] nit --- libc/test/src/math/smoke/FMinimumTest.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libc/test/src/math/smoke/FMinimumTest.h b/libc/test/src/math/smoke/FMinimumTest.h index 6770fdd2e648c..f8976ad838496 100644 --- a/libc/test/src/math/smoke/FMinimumTest.h +++ b/libc/test/src/math/smoke/FMinimumTest.h @@ -68,7 +68,7 @@ class FMinimumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest { continue; T x = xbits.get_val(); T y = ybits.get_val(); - if ((x == 0) && (y == 0)) + if ((x == T(0)) && (y == T(0))) continue; if (x > y) _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
