kazutakahirata wrote:

Thank you for working on this!  Since we're both using LLMs here, I'm listing 
findings in one place so you can feed this directly to your agent rather than 
clicking through inline diff threads:

1. **`llvm/docs/SecurityTransparencyReports.md` (lines 111–161, `## 2023` 
section):**
   When the `## 2023` list was unindented from a blockquote to a native list, 
the `<...>` autolink brackets were dropped around all 26 `https://...` URLs in 
that section (unlike `## 2022` and `## 2024`). Since MyST `linkify` is off in 
`llvm/docs/conf.py`, those 26 URLs currently render as non-clickable plain 
text. Please wrap the bare URLs in `## 2023` in `<https://...>` (and wrap 
`__builtin_unreachable()` on line 123 in backticks).

2. **`llvm/docs/XRay.md` (lines 297–298):**
   The original `.rst` link was missing a trailing `_`, so `rst2myst` turned it 
into `{title-reference}` instead of a link:
   - Replace `{title-reference}`Chrome Trace Viewer (catapult)\n  
<https://github.com/catapult-project/catapult>`` with `[Chrome Trace Viewer 
(catapult)](https://github.com/catapult-project/catapult)`.

3. **Leftover `{title-reference}` roles that should be inline code (`` `...` 
``):**
   - `llvm/docs/Security.md` (line 29): `{title-reference}`* ${full_name} 
(${affiliation}) [${github_username}]`` -> `` `* ${full_name} (${affiliation}) 
[${github_username}]` ``
   - `llvm/docs/TransformMetadata.md` (line 393): `{title-reference}`B[0]`` -> 
`` `B[0]` ``
   - `llvm/docs/XRay.md` (line 86): `{title-reference}`libclang_rt.xray-{arch}` 
where {title-reference}`{arch}`` -> `` `libclang_rt.xray-{arch}` where `{arch}` 
``

4. **Single-backtick code identifiers converted to `*italics*` instead of `` 
`code` ``:**
   - `llvm/docs/StackMaps.md` (lines 47–50): `*GCFunctionMetadata*` (x2) and 
`*GCRoot*` -> `` `GCFunctionMetadata` `` and `` `GCRoot` ``
   - `llvm/docs/TableGen/ProgRef.md`:
     - Lines 593–594: `*int*` and `*list\<int>*` -> `` `int` `` and `` 
`list<int>` ``
     - Line 1349: `*deftype*` -> `` `deftype` ``
     - Line 1420: `*dump*` -> `` `dump` ``
     - Line 1429: `*!repr*` -> `` `!repr` ``
     - Lines 2073–2075: `*[0, 1, 2, 3]*`, `*[1, 2, 3]*`, `*[0, 2]*` -> `` `[0, 
1, 2, 3]` ``, `` `[1, 2, 3]` ``, `` `[0, 2]` ``

https://github.com/llvm/llvm-project/pull/223100
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to