Hi, 2014-05-18 22:37 GMT+02:00 Vesa <dii....@nbl.fi>: > Speaking of, it seems that the VST frame delta isn't being set correctly > maybe? Grejppi said on IRC that he tested it and that the offset > parameter that gets passed to Vestige is always 0... could be that we're > looking at the wrong part there, but...
Yes, this is probably somewhat broken as VeSTige responds to MIDI events only and does not overload playNote() & friends. That way MIDI NoteOn/NoteOff events generated inside the NotePlayHandles are forwarded to the VST plugin. In the NotePlayHandle constructor you can see that a conversion from offset frames to MidiTime takes place at the very bottom. With small period sizes this will almost certainly always return a MidiTime object with 0 ticks. It looks like we really should make playback either frame-based (as you proposed already) and skip all the MidiTime <-> frame conversions or add an additional field to the MidiTime structure holding the frame information. Toby ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ LMMS-devel mailing list LMMS-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lmms-devel
