On 05/22/2014 12:48 PM, Tobias Doerffel wrote: > Yes, this is probably somewhat broken as VeSTige responds to MIDI > events only and does not overload playNote() & friends. That way MIDI > NoteOn/NoteOff events generated inside the NotePlayHandles are > forwarded to the VST plugin. In the NotePlayHandle constructor you can > see that a conversion from offset frames to MidiTime takes place at > the very bottom. With small period sizes this will almost certainly > always return a MidiTime object with 0 ticks. It looks like we really > should make playback either frame-based (as you proposed already) and > skip all the MidiTime <-> frame conversions or add an additional field > to the MidiTime structure holding the frame information. Toby
Seems like the playPos structure which is used in song.cpp to hold the current play position is a child of MidiTime, and has an additional frame offset property. I think possibly we could just copy those properties into MidiTime, and have the playposition in song use plain MidiTime - that way, those properties could be used everywhere... Making playback frame-based (or, rehauling the entire timing system) would probably be a huge task which would require lots of cooperation and coordination, and probably not something we should tackle now... perhaps for 2.0? ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ LMMS-devel mailing list LMMS-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lmms-devel
