On 06/20/2014 09:58 AM, ycollette.nos...@free.fr wrote: > Hello, > > Recently, I tried to commit something to allow the user to change the color > of sample tracks of a song. > I would to give it another try by including the work recently done on the > bb_track: being able to change the color of the sample tracks (background and > signal), being able to reset to color of the style. > After that, I would like to port this to the other tracks. > > Being able to change the color of the tracks is, for me, a good thing because > it allows to structure a song. > > Do you have some opinion on that ? >
Well, I'm going to say that personally, I'd rather we didn't have the option for even bb-track colouring and would like to see that go away, and wouldn't want the same function for sampletracks either. I think it's a bad feature, with a whole set of problems that comes with it. However, that's just my opinion and I know some people love the bb-track-paint-by-numbers option, so take it for what it's worth. So instead of complaining I'm just going to concentrate on the problems (that also exist with the bb-track colouring function) and maybe if we can solve those, this functionality could be moved forward. The main issue is incompatibility with themes. This is partly addressed in the way bb-track-colouring is implemented now, but there's still some problems remaining. An example: say you have a very light theme where the song editor background is very light, and you colour your tracks black or some dark colour. Then later, you or someone else opens the project, but this time using a very dark theme, where the song editor background is very dark. Now the tracks are hard to see, possibly even invisible to some... What I think should be done before any more colourizing functionality is added is to add a settings option to "disable custom colours", and maybe also an option to "reset all track colours" that can strip away all custom colours from a project. This way the potential usability/accessibility problems these features can cause can at least be mitigated. Also, for the record, I think having two colour properties for sample tracks would get too complicated. IMO, better to just have the background colour changeable, and the fg colour can always use the theme colour. But this is again just my opinion. ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ LMMS-devel mailing list LMMS-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lmms-devel
