On 2014-11-13 16:14, [email protected] wrote:
> From: Alexandru Badicioiu <[email protected]>
>
> This patch adds a suite for sync and async inplace mode of crypto APIs.
> Correctness of crypto operation output is verified with known test
> vectors. Various options and functionalities like use session IV
> or operation IV for ciphering are exercised for both modes.
> For async mode there are options to use input packet buffer or a
> separate buffer as the completion event and to set and retrieve the
> context associated with an operation from the completion event.
>
> Signed-off-by: Alexandru Badicioiu <[email protected]>
I haven't had time to look into this patch will send feedback later
today.
one thing is it doesn't build:
Making all in crypto
make[3]: Entering directory '/home/anders/src/check-odp/odp/test/cunit/crypto'
CC odp_crypto-odp_crypto_test_async_inp.o
odp_crypto_test_async_inp.c:364:2: error: initialization discards ‘const’
qualifier from pointer target type [-Werror]
{ASYNC_INP_ENC_ALG_3DES_CBC, test_async_enc_alg_3des_cbc },
^
odp_crypto_test_async_inp.c:365:2: error: initialization discards ‘const’
qualifier from pointer target type [-Werror]
{ASYNC_INP_DEC_ALG_3DES_CBC, test_async_dec_alg_3des_cbc },
^
odp_crypto_test_async_inp.c:366:2: error: initialization discards ‘const’
qualifier from pointer target type [-Werror]
{ASYNC_INP_ENC_ALG_3DES_CBC_OVR_IV, test_async_enc_alg_3des_cbc_ovr_iv },
^
odp_crypto_test_async_inp.c:367:2: error: initialization discards ‘const’
qualifier from pointer target type [-Werror]
{ASYNC_INP_DEC_ALG_3DES_CBC_OVR_IV, test_async_dec_alg_3des_cbc_ovr_iv },
^
odp_crypto_test_async_inp.c:368:2: error: initialization discards ‘const’
qualifier from pointer target type [-Werror]
{ASYNC_INP_ALG_HMAC_MD5, test_async_alg_hmac_md5 },
^
odp_crypto_test_async_inp.c:369:2: error: initialization discards ‘const’
qualifier from pointer target type [-Werror]
{ASYNC_INP_ENC_ALG_3DES_CBC_COMPL_NEW, test_async_enc_alg_3des_cbc_compl_new
},
^
cc1: all warnings being treated as errors
Makefile:456: recipe for target 'odp_crypto-odp_crypto_test_async_inp.o' failed
make[3]: *** [odp_crypto-odp_crypto_test_async_inp.o] Error 1
make[3]: Leaving directory '/home/anders/src/check-odp/odp/test/cunit/crypto'
Makefile:732: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
Makefile:369: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
Makefile:454: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
Making check in crypto
Check patch compliains on this:
WARNING: braces {} are not necessary for any arm of this statement
#304: FILE: test/cunit/crypto/odp_crypto_test_async_inp.c:114:
+ if (compl_new == ODP_BUFFER_INVALID) {
[...]
+ } else {
[...]
WARNING: line over 80 characters
#556: FILE: test/cunit/crypto/odp_crypto_test_async_inp.c:366:
+ {ASYNC_INP_ENC_ALG_3DES_CBC_OVR_IV, test_async_enc_alg_3des_cbc_ovr_iv
},
WARNING: line over 80 characters
#557: FILE: test/cunit/crypto/odp_crypto_test_async_inp.c:367:
+ {ASYNC_INP_DEC_ALG_3DES_CBC_OVR_IV, test_async_dec_alg_3des_cbc_ovr_iv
},
WARNING: line over 80 characters
#559: FILE: test/cunit/crypto/odp_crypto_test_async_inp.c:369:
+ {ASYNC_INP_ENC_ALG_3DES_CBC_COMPL_NEW,
test_async_enc_alg_3des_cbc_compl_new },
Cheers,
Anders
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp
