Maxim,
I see you have a different CUnit than me. This is from
~/CUnit-2.1-3/CUnit/Headers/TestDB.h:
/**
* Test case parameters structure.
* This data type is provided to assist CUnit users manage collections of
* tests and suites. It is intended to be used to build arrays of test
case
* parameters that can be then be referred to in a CU_suite_info_t
variable.
*/
typedef struct CU_TestInfo {
*const char *pName; * /**< Test name. */
CU_TestFunc pTestFunc; /**< Test function. */
} CU_TestInfo;
On 14 November 2014 14:59, Maxim Uvarov <[email protected]> wrote:
> On 11/14/2014 03:04 PM, Alexandru Badicioiu wrote:
>
>> I have the same compilation line:
>>
>> powerpc-fsl_networking-linux-gcc --sysroot=/dnyocto/yocto_
>> common/git/sdk-1.5/build_p4080ds_release/tmp/sysroots/p4080ds
>> -DHAVE_CONFIG_H -I. -pthread -DODP_DEBUG_PRINT=1 -DODP_DEBUG=1 -W -Wall
>> -Werror -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations
>> -Wold-style-definition -Wpointer-arith -Wcast-align -Wnested-externs
>> -Wcast-qual -Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings
>> -I. -I../../../platform/linux-generic/include/api
>> -I../../../platform/linux-generic/include/api -I../../../helper/include
>> -I/var/lib/tftpboot/rootfs-e500mc-32bit/usr/local//include -g -O2 -MT
>> odp_crypto-odp_crypto_test_async_inp.o -MD -MP -MF
>> .deps/odp_crypto-odp_crypto_test_async_inp.Tpo -c -o
>> odp_crypto-odp_crypto_test_async_inp.o `test -f
>> 'odp_crypto_test_async_inp.c' || echo './'`odp_crypto_test_async_inp.c
>>
>> but it seems that your compiler says that the initialization of
>> test_array_async array discards the const of ASYNC_INP_ENC_ALG_3DES_CBC:
>>
>> #define ASYNC_INP_ENC_ALG_3DES_CBC "ENC_ALG_3DES_CBC"
>> CU_TestInfo test_array_async[] = {
>> {ASYNC_INP_ENC_ALG_3DES_CBC, enc_alg_3des_cbc },
>>
>> Could you please try adding const attribute to the array?
>> + const CU_TestInfo test_array_async[] = {
>> {ASYNC_INP_ENC_ALG_3DES_CBC, enc_alg_3des_cbc },
>>
>> Thanks,
>> Alex
>>
>
> Alex that will not work. Cunit expects char*. While #define
> ASYNC_INP_ENC_ALG_3DES_CBC "ENC_ALG_3DES_CBC"
> is const char:
>
> typedef struct CU_TestInfo {
> char *pName; /**< Test name. */
> CU_TestFunc pTestFunc; /**< Test function. */
> } CU_TestInfo;
>
> I don't think cunit modifies that name. So it's mostly cunit problem then
> ours. Might be we can disable this warning for that
> particular place.
>
> Maxim.
>
>
>
>> On 14 November 2014 13:42, Maxim Uvarov <[email protected] <mailto:
>> [email protected]>> wrote:
>>
>> On 11/14/2014 12:49 PM, Alexandru Badicioiu wrote:
>>
>> Hi,
>> for build errors - which compiler/toolchain do you use?
>>
>>
>> Alex, I see the same with:
>>
>> COLLECT_GCC=gcc
>> COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.6/lto-wrapper
>> Target: x86_64-linux-gnu
>> Configured with: ../src/configure -v
>> --with-pkgversion='Ubuntu/Linaro 4.6.3-1ubuntu5'
>> --with-bugurl=file:///usr/share/doc/gcc-4.6/README.Bugs
>> --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr
>> --program-suffix=-4.6 --enable-shared --enable-linker-build-id
>> --with-system-zlib --libexecdir=/usr/lib
>> --without-included-gettext --enable-threads=posix
>> --with-gxx-include-dir=/usr/include/c++/4.6 --libdir=/usr/lib
>> --enable-nls --with-sysroot=/ --enable-clocale=gnu
>> --enable-libstdcxx-debug --enable-libstdcxx-time=yes
>> --enable-gnu-unique-object --enable-plugin --enable-objc-gc
>> --disable-werror --with-arch-32=i686 --with-tune=generic
>> --enable-checking=release --build=x86_64-linux-gnu
>> --host=x86_64-linux-gnu --target=x86_64-linux-gnu
>> Thread model: posix
>> gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
>>
>> gcc -DHAVE_CONFIG_H -I. -pthread -DODP_DEBUG_PRINT=1 -DODP_DEBUG=1
>> -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes
>> -Wmissing-declarations -Wold-style-definition -Wpointer-arith
>> -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral
>> -Wformat-security -Wundef -Wwrite-strings -I.
>> -I../../../platform/linux-generic/include/api
>> -I../../../platform/linux-generic/include/api
>> -I../../../helper/include -I/include -g -O2 -MT
>> odp_crypto-odp_crypto_test_async_inp.o -MD -MP -MF
>> .deps/odp_crypto-odp_crypto_test_async_inp.Tpo -c -o
>> odp_crypto-odp_crypto_test_async_inp.o `test -f
>> 'odp_crypto_test_async_inp.c' || echo './'`odp_crypto_test_async_
>> inp.c
>> odp_crypto_test_async_inp.c:363:2: error: initialization discards
>> 'const' qualifier from pointer target type [-Werror]
>> odp_crypto_test_async_inp.c:364:2: error: initialization discards
>> 'const' qualifier from pointer target type [-Werror]
>> odp_crypto_test_async_inp.c:365:2: error: initialization discards
>> 'const' qualifier from pointer target type [-Werror]
>> odp_crypto_test_async_inp.c:366:2: error: initialization discards
>> 'const' qualifier from pointer target type [-Werror]
>> odp_crypto_test_async_inp.c:367:2: error: initialization discards
>> 'const' qualifier from pointer target type [-Werror]
>> odp_crypto_test_async_inp.c:368:2: error: initialization discards
>> 'const' qualifier from pointer target type [-Werror]
>> cc1: all warnings being treated as errors
>> make: *** [odp_crypto-odp_crypto_test_async_inp.o] Error 1
>>
>> Maxim.
>>
>>
>> I did not modify in any way compilation flags and I have no
>> problem with building with a PPC toolchain and also with the
>> native gcc on my development machine? I use CUnit-2.1-3.
>>
>> WARNING: braces {} are not necessary for any arm of this statement
>> #304: FILE: test/cunit/crypto/odp_crypto_test_async_inp.c:114:
>> + if (compl_new == ODP_BUFFER_INVALID) {
>> [...]
>> + } else {
>> [...]
>> If we remove the braces the test will not compile, it seems
>> the CUnit macros are the problem.
>> I'll shorten the lines over 80 characters.
>>
>> Alex
>>
>>
>> On 14 November 2014 10:23, Anders Roxell
>> <[email protected] <mailto:[email protected]>
>> <mailto:[email protected]
>> <mailto:[email protected]>>> wrote:
>>
>> On 2014-11-13 16:14, [email protected]
>> <mailto:[email protected]>
>> <mailto:[email protected]
>> <mailto:[email protected]>> wrote:
>> > From: Alexandru Badicioiu
>> <[email protected]
>> <mailto:[email protected]>
>> <mailto:[email protected]
>> <mailto:[email protected]>>>
>> >
>> > This patch adds a suite for sync and async inplace mode of
>> crypto APIs.
>> > Correctness of crypto operation output is verified with
>> known test
>> > vectors. Various options and functionalities like use
>> session IV
>> > or operation IV for ciphering are exercised for both modes.
>> > For async mode there are options to use input packet
>> buffer or a
>> > separate buffer as the completion event and to set and
>> retrieve the
>> > context associated with an operation from the completion
>> event.
>> >
>> > Signed-off-by: Alexandru Badicioiu
>> <[email protected]
>> <mailto:[email protected]>
>> <mailto:[email protected]
>>
>> <mailto:[email protected]>>>
>>
>>
>> I haven't had time to look into this patch will send
>> feedback later
>> today.
>>
>> one thing is it doesn't build:
>>
>> Making all in crypto
>> make[3]: Entering directory
>> '/home/anders/src/check-odp/odp/test/cunit/crypto'
>> CC odp_crypto-odp_crypto_test_async_inp.o
>> odp_crypto_test_async_inp.c:364:2: error: initialization
>> discards
>> ‘const’ qualifier from pointer target type [-Werror]
>> {ASYNC_INP_ENC_ALG_3DES_CBC, test_async_enc_alg_3des_cbc },
>> ^
>> odp_crypto_test_async_inp.c:365:2: error: initialization
>> discards
>> ‘const’ qualifier from pointer target type [-Werror]
>> {ASYNC_INP_DEC_ALG_3DES_CBC, test_async_dec_alg_3des_cbc },
>> ^
>> odp_crypto_test_async_inp.c:366:2: error: initialization
>> discards
>> ‘const’ qualifier from pointer target type [-Werror]
>> {ASYNC_INP_ENC_ALG_3DES_CBC_OVR_IV,
>> test_async_enc_alg_3des_cbc_ovr_iv },
>> ^
>> odp_crypto_test_async_inp.c:367:2: error: initialization
>> discards
>> ‘const’ qualifier from pointer target type [-Werror]
>> {ASYNC_INP_DEC_ALG_3DES_CBC_OVR_IV,
>> test_async_dec_alg_3des_cbc_ovr_iv },
>> ^
>> odp_crypto_test_async_inp.c:368:2: error: initialization
>> discards
>> ‘const’ qualifier from pointer target type [-Werror]
>> {ASYNC_INP_ALG_HMAC_MD5, test_async_alg_hmac_md5 },
>> ^
>> odp_crypto_test_async_inp.c:369:2: error: initialization
>> discards
>> ‘const’ qualifier from pointer target type [-Werror]
>> {ASYNC_INP_ENC_ALG_3DES_CBC_COMPL_NEW,
>> test_async_enc_alg_3des_cbc_compl_new },
>> ^
>> cc1: all warnings being treated as errors
>> Makefile:456: recipe for target
>> 'odp_crypto-odp_crypto_test_async_inp.o' failed
>> make[3]: *** [odp_crypto-odp_crypto_test_async_inp.o] Error 1
>> make[3]: Leaving directory
>> '/home/anders/src/check-odp/odp/test/cunit/crypto'
>> Makefile:732: recipe for target 'all-recursive' failed
>> make[2]: *** [all-recursive] Error 1
>> Makefile:369: recipe for target 'all-recursive' failed
>> make[1]: *** [all-recursive] Error 1
>> Makefile:454: recipe for target 'all-recursive' failed
>> make: *** [all-recursive] Error 1
>> Making check in crypto
>>
>> Check patch compliains on this:
>> WARNING: braces {} are not necessary for any arm of this
>> statement
>> #304: FILE: test/cunit/crypto/odp_crypto_
>> test_async_inp.c:114:
>> + if (compl_new == ODP_BUFFER_INVALID) {
>> [...]
>> + } else {
>> [...]
>>
>> WARNING: line over 80 characters
>> #556: FILE: test/cunit/crypto/odp_crypto_
>> test_async_inp.c:366:
>> + {ASYNC_INP_ENC_ALG_3DES_CBC_OVR_IV,
>> test_async_enc_alg_3des_cbc_ovr_iv },
>>
>> WARNING: line over 80 characters
>> #557: FILE: test/cunit/crypto/odp_crypto_
>> test_async_inp.c:367:
>> + {ASYNC_INP_DEC_ALG_3DES_CBC_OVR_IV,
>> test_async_dec_alg_3des_cbc_ovr_iv },
>>
>> WARNING: line over 80 characters
>> #559: FILE: test/cunit/crypto/odp_crypto_
>> test_async_inp.c:369:
>> + {ASYNC_INP_ENC_ALG_3DES_CBC_COMPL_NEW,
>> test_async_enc_alg_3des_cbc_compl_new },
>>
>>
>> Cheers,
>> Anders
>>
>>
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> [email protected] <mailto:[email protected]>
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> [email protected] <mailto:[email protected]>
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>>
>>
>
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp
