On 11/14/2014 03:48 PM, Alexandru Badicioiu wrote:
I have no idea what is CUnit-2.1-3 specific stuff. Just download it
and build it.
Alex
Mine is ubuntu Version: 2.1-0.dfsg-9.
So we need to add to ./configure check that 2.1.-3 is required.
Or you can malloc that names. I think it's better to switch to new
version if code is fixed in cunit.
Maxim.
On 14 November 2014 14:35, Anders Roxell <[email protected]
<mailto:[email protected]>> wrote:
On 2014-11-14 11:49, Alexandru Badicioiu wrote:
> Hi,
> for build errors - which compiler/toolchain do you use? I did
not modify in
> any way compilation flags and I have no problem with building
with a PPC
> toolchain and also with the native gcc on my development
machine? I use
> CUnit-2.1-3.
Hi,
Ubuntu 14.10:
# gcc --version
gcc (Ubuntu 4.9.1-16ubuntu6) 4.9.1
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.
# dpkg -s libcunit1-dev
Package: libcunit1-dev
Status: install ok installed
Priority: optional
Section: libdevel
Installed-Size: 285
Maintainer: Ubuntu Developers
<[email protected]
<mailto:[email protected]>>
Architecture: amd64
Source: cunit
Version: 2.1-2.dfsg-1
Depends: libcunit1 (= 2.1-2.dfsg-1)
Suggests: libcunit1-doc (= 2.1-2.dfsg-1)
Does *not* build!
Ubuntu 14.04:
# gcc --version
gcc (Ubuntu 4.8.2-19ubuntu1) 4.8.2
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.
# dpkg -s libcunit1-dev
Package: libcunit1-dev
Status: install ok installed
Priority: optional
Section: libdevel
Installed-Size: 285
Maintainer: Ubuntu Developers
<[email protected]
<mailto:[email protected]>>
Architecture: amd64
Source: cunit
Version: 2.1-2.dfsg-1
Depends: libcunit1 (= 2.1-2.dfsg-1)
Suggests: libcunit1-doc (= 2.1-2.dfsg-1)
Does *not* build!
Builds:
cross compiling with linaro toolchain release 14.09 + CUnit
version 2.1-3
Do you use some 2.1-3 specific CUnit stuff?
Cheers,
Anders
>
> WARNING: braces {} are not necessary for any arm of this statement
> #304: FILE: test/cunit/crypto/odp_crypto_test_async_inp.c:114:
> + if (compl_new == ODP_BUFFER_INVALID) {
> [...]
> + } else {
> [...]
> If we remove the braces the test will not compile, it seems the
CUnit
> macros are the problem.
> I'll shorten the lines over 80 characters.
>
> Alex
>
>
> On 14 November 2014 10:23, Anders Roxell
<[email protected] <mailto:[email protected]>> wrote:
>
> > On 2014-11-13 16:14, [email protected]
<mailto:[email protected]> wrote:
> > > From: Alexandru Badicioiu <[email protected]
<mailto:[email protected]>>
> > >
> > > This patch adds a suite for sync and async inplace mode of
crypto APIs.
> > > Correctness of crypto operation output is verified with
known test
> > > vectors. Various options and functionalities like use session IV
> > > or operation IV for ciphering are exercised for both modes.
> > > For async mode there are options to use input packet buffer or a
> > > separate buffer as the completion event and to set and
retrieve the
> > > context associated with an operation from the completion event.
> > >
> > > Signed-off-by: Alexandru Badicioiu
<[email protected]
<mailto:[email protected]>>
> >
> > I haven't had time to look into this patch will send feedback
later
> > today.
> >
> > one thing is it doesn't build:
> >
> > Making all in crypto
> > make[3]: Entering directory
> > '/home/anders/src/check-odp/odp/test/cunit/crypto'
> > CC odp_crypto-odp_crypto_test_async_inp.o
> > odp_crypto_test_async_inp.c:364:2: error: initialization
discards ‘const’
> > qualifier from pointer target type [-Werror]
> > {ASYNC_INP_ENC_ALG_3DES_CBC, test_async_enc_alg_3des_cbc },
> > ^
> > odp_crypto_test_async_inp.c:365:2: error: initialization
discards ‘const’
> > qualifier from pointer target type [-Werror]
> > {ASYNC_INP_DEC_ALG_3DES_CBC, test_async_dec_alg_3des_cbc },
> > ^
> > odp_crypto_test_async_inp.c:366:2: error: initialization
discards ‘const’
> > qualifier from pointer target type [-Werror]
> > {ASYNC_INP_ENC_ALG_3DES_CBC_OVR_IV,
test_async_enc_alg_3des_cbc_ovr_iv },
> > ^
> > odp_crypto_test_async_inp.c:367:2: error: initialization
discards ‘const’
> > qualifier from pointer target type [-Werror]
> > {ASYNC_INP_DEC_ALG_3DES_CBC_OVR_IV,
test_async_dec_alg_3des_cbc_ovr_iv },
> > ^
> > odp_crypto_test_async_inp.c:368:2: error: initialization
discards ‘const’
> > qualifier from pointer target type [-Werror]
> > {ASYNC_INP_ALG_HMAC_MD5, test_async_alg_hmac_md5 },
> > ^
> > odp_crypto_test_async_inp.c:369:2: error: initialization
discards ‘const’
> > qualifier from pointer target type [-Werror]
> > {ASYNC_INP_ENC_ALG_3DES_CBC_COMPL_NEW,
> > test_async_enc_alg_3des_cbc_compl_new },
> > ^
> > cc1: all warnings being treated as errors
> > Makefile:456: recipe for target
'odp_crypto-odp_crypto_test_async_inp.o'
> > failed
> > make[3]: *** [odp_crypto-odp_crypto_test_async_inp.o] Error 1
> > make[3]: Leaving directory
> > '/home/anders/src/check-odp/odp/test/cunit/crypto'
> > Makefile:732: recipe for target 'all-recursive' failed
> > make[2]: *** [all-recursive] Error 1
> > Makefile:369: recipe for target 'all-recursive' failed
> > make[1]: *** [all-recursive] Error 1
> > Makefile:454: recipe for target 'all-recursive' failed
> > make: *** [all-recursive] Error 1
> > Making check in crypto
> >
> > Check patch compliains on this:
> > WARNING: braces {} are not necessary for any arm of this statement
> > #304: FILE: test/cunit/crypto/odp_crypto_test_async_inp.c:114:
> > + if (compl_new == ODP_BUFFER_INVALID) {
> > [...]
> > + } else {
> > [...]
> >
> > WARNING: line over 80 characters
> > #556: FILE: test/cunit/crypto/odp_crypto_test_async_inp.c:366:
> > + {ASYNC_INP_ENC_ALG_3DES_CBC_OVR_IV,
> > test_async_enc_alg_3des_cbc_ovr_iv },
> >
> > WARNING: line over 80 characters
> > #557: FILE: test/cunit/crypto/odp_crypto_test_async_inp.c:367:
> > + {ASYNC_INP_DEC_ALG_3DES_CBC_OVR_IV,
> > test_async_dec_alg_3des_cbc_ovr_iv },
> >
> > WARNING: line over 80 characters
> > #559: FILE: test/cunit/crypto/odp_crypto_test_async_inp.c:369:
> > + {ASYNC_INP_ENC_ALG_3DES_CBC_COMPL_NEW,
> > test_async_enc_alg_3des_cbc_compl_new },
> >
> >
> > Cheers,
> > Anders
> >
--
Anders Roxell
[email protected] <mailto:[email protected]>
M: +46 709 71 42 85 <tel:%2B46%20709%2071%2042%2085> | IRC: roxell
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp