On Wed, Nov 26, 2014 at 04:32:43PM +0200, Taras Kondratiuk wrote: > On 11/26/2014 04:05 PM, Maxim Uvarov wrote: > >On 11/26/2014 04:33 PM, Taras Kondratiuk wrote: > >>On 11/26/2014 03:23 PM, Jerin Jacob wrote: > >>>On Wed, Nov 26, 2014 at 02:53:50PM +0300, Maxim Uvarov wrote: > >>>>On 11/26/2014 12:25 PM, Ola Liljedahl wrote: > >>>>>On 26 November 2014 at 09:39, Alexandru Badicioiu > >>>>><[email protected]> wrote: > >>>>>>This patch has no description. The title is not self explanatory > >>>>>>either. > >>>>>>Also the existence of eth0 should be verified before mapping the > >>>>>>loop0 to > >>>>>>eth0 - some platforms may use other interface names (e.g. fmX-gby > >>>>>>for FSL > >>>>>>DPAA platforms). I think a better solution would be to enumerate the > >>>>>>available interfaces and pick a suitable one. > >>>>>I second that opinion. On my ChromeBook (great development > >>>>>platforms!), the only Ethernet-like > >>>>>interface is called mlan0. > >>>>Hm, renaming should be done to some predictable name. eth0 is very > >>>>common > >>>>for linux. > >>>>If it's not so that can be changed with export > >>>>ODP_PKTIO_LOOPDEV="mlan0". > >>>> > >>>>I can walk over the list but not sure how to select interface that > >>>>can be > >>>>used. > >>> > >>>IMO we should have an ODP API to enumerate all the available pktio > >>>ports > >>>in a given platform as strings along with a bitmap to represent their > >>>capability(like PKTIO_CAP_LOOPBACK) > >>>So that application can choose the pktio based on the capability. > >>>We can use our odp_xxxx_xxxx_next API model for enumeration. > >> > >>+1 > >> > >>Instead of bitmap it can some struct. > > > > > >Any hint how that can be implemented on linux-generic for v1? > > SIOCGIFCONF ioctl can be used to get a list of interfaces. > Or read /proc/net/dev directly. Then read flags with SIOCGIFFLAGS ioctl. > > I'm not sure if we need this for v1. >
I started doing some of this a couple of weeks back [1]. It's easy enough to find the available interfaces but the difficult part is figuring out if those interfaces can be used by ODP (I didn't get that far), and how much of this is a system/implementation problem vs being an application/user problem? For example I presume you'd want to exclude management ports.. and messing with settings such as MTU on shared interfaces (including "lo") is sure to cause problems. Maybe you could filter out interfaces that have IPs assigned?.. Anyway, I think interface enumeration would be good to have but I don't think it's needed for 1.0. -- Stuart. [1] https://git.linaro.org/people/stuart.haslam/odp.git/commit/3671a175d82c51c825f28d103fcc8da152a233d3 _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
