On 15 December 2014 at 13:45, Savolainen, Petri (NSN - FI/Espoo) <[email protected]> wrote: > Otherwise OK, but shouldn't remove the timer example. I also think it is good to have a timer example. Just shouldn't be called odp_timer_test. Since we don't have any other timer example, this one will have to do for now.
> > Why it's a bad example? I think we need a set of simple examples. It would > also demonstrate how to step out from a schedule loop (== pause -> schedule > until ODP_BUFFER_INVALID is returned -> tear down / step out). > > The new timer example could be more performance oriented, etc. What is that that we want to demonstrate? 1) basic timer usage (single-threaded?) 2) multithreaded, combining timer and scheduler 3) more? Can you be more specific with "more performance oriented"? > > > -Petri > > > >> -----Original Message----- >> From: [email protected] [mailto:lng-odp- >> [email protected]] On Behalf Of ext Mike Holmes >> Sent: Friday, December 12, 2014 8:35 PM >> To: [email protected] >> Subject: [lng-odp] [PATCH 0/3] Remove odp_schedule_one for 1.0 compliance >> >> The 1.0 API delta doc specifies that odp_schedule_one should be removed. >> This series does that. In doing so it is expedient to just delete the >> timer >> example because it is a poor example and there are patches under >> consideration >> that improve the timer implementation and replace this bad example. >> >> Mike Holmes (3): >> example: odp_example: remove use of odp_schdule_one >> example: odp_timer_test: delete bad example >> api: schedule: remove odp_schedule_one >> >> example/Makefile.am | 2 +- >> example/odp_example/odp_example.c | 140 -------- >> example/timer/.gitignore | 1 - >> example/timer/Makefile.am | 7 - >> example/timer/odp_timer_test.c | 389 ----------------- >> ----- >> platform/linux-generic/include/api/odp_schedule.h | 25 -- >> platform/linux-generic/odp_schedule.c | 12 - >> 7 files changed, 1 insertion(+), 575 deletions(-) >> delete mode 100644 example/timer/.gitignore >> delete mode 100644 example/timer/Makefile.am >> delete mode 100644 example/timer/odp_timer_test.c >> >> -- >> 2.1.0 >> >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> http://lists.linaro.org/mailman/listinfo/lng-odp > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
