That's good to know, because the short log indeed does not say that. :) Rather than commenting on these for each patch posted, why not update the CONTRIBUTING file with a detailed summary of how ODP commit messages should be formatted, including examples for the various common cases of fixing bugs, adding features, performance enhancements, examples, tests, etc.? Also include what should and should not be placed above and below the s-o-b, again with examples illustrating correct form for the common cases.
We can then all simply refer to this and use it as a model. This will save a lot of noise on the review lists so that we can focus on reviewing the code rather than how the code is packaged. Thanks. On Fri, Dec 19, 2014 at 3:27 PM, Anders Roxell <[email protected]> wrote: > > The short log should not say: > "example: buffer_timer_test: fix bad commit <short hash>" > > > > On 19 December 2014 at 21:20, Bill Fischofer <[email protected]> > wrote: > > Signed-off-by: Bill Fischofer <[email protected]> > > --- > > Test was not properly updated to run with new buffer pool structure. > Added > > an explicit buffer number. > > This good description should be above the s-o-b (Signed-off-by) =) > > Cheers, > Anders > > > > > example/timer/odp_timer_test.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/example/timer/odp_timer_test.c > b/example/timer/odp_timer_test.c > > index 0d6e31a..c754695 100644 > > --- a/example/timer/odp_timer_test.c > > +++ b/example/timer/odp_timer_test.c > > @@ -27,6 +27,7 @@ > > > > #define MAX_WORKERS 32 /**< Max worker threads */ > > #define MSG_POOL_SIZE (4*1024*1024) /**< Message pool size */ > > +#define MSG_NUM_BUFS 10000 /**< Number of timers */ > > > > > > /** Test arguments */ > > @@ -316,7 +317,7 @@ int main(int argc, char *argv[]) > > > > params.buf_size = 0; > > params.buf_align = 0; > > - params.num_bufs = MSG_POOL_SIZE; > > + params.num_bufs = MSG_NUM_BUFS; > > params.buf_type = ODP_BUFFER_TYPE_TIMEOUT; > > > > pool = odp_buffer_pool_create("msg_pool", shm, ¶ms); > > -- > > 1.8.3.2 > > > > _______________________________________________ > > lng-odp mailing list > > [email protected] > > http://lists.linaro.org/mailman/listinfo/lng-odp >
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
