On 14 January 2015 at 21:50, Taras Kondratiuk <[email protected]> wrote: > On 01/14/2015 09:07 PM, Stuart Haslam wrote: >> On Thu, Dec 18, 2014 at 10:27:43AM +0000, Taras Kondratiuk wrote: >>> PKTIN queue was not handled correctly. Check queue status instead of >>> queue type. >>> >> >> I just had cause to want to destroy a PKTIN queue and remembered this >> patch. I applied it and tested but get a SEGV in queue_deq_multi_destroy >> when trying to free queue->s.sched_buf as it's ODP_BUFFER_INVALID, which >> seems to be due to it being called twice for the same queue. > > Could you please push your test code somewhere? > I don't see where it can be called twice. > > BTW should odp_buffer_free(ODP_BUFFER_INVALID) cause SEGV? Yes or play a game of tic-tac-toe. Or anything else. I see odp_buffer_free() as performance critical and would like to be able to avoid any parameter checks. Your implementation may check the buffer handle but passing an invalid handle is an illegal operation and must not be treated as if it is OK. Calling abort() is fine.
> > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
