It is not replaced by odp_event_t.  odp_buffer_t is the abstract type for
ODP buffers.  odp_event_t is the abstract type for events, which are new.

On Fri, Jan 16, 2015 at 9:39 AM, Ola Dahl <[email protected]> wrote:

> I am wondering why odp_buffer_t is still around, when it is supposed to be
> replaced by odp_event_t?
>
> Best regards,
>
> Ola D
>
>
> On Fri Jan 16 2015 at 4:18:36 PM Bill Fischofer <[email protected]>
> wrote:
>
>> odp_buffer.c is the implementation of all of the APIs defined in
>> odp_buffer.h.  I'm not sure what you're asking here.
>>
>> On Fri, Jan 16, 2015 at 9:12 AM, Ola Dahl <[email protected]> wrote:
>>
>>> On 2015-01-15 16:40, Petri Savolainen wrote:
>>>
>>>> This patches introduces odp_event_t and replaces with that the usage of
>>>> odp_buffer_t as the super class for other "buffer types". What used to
>>>> be a
>>>> buffer type is now an event type.
>>>>
>>>
>>> I wonder why odp_buffer_t is still kept?
>>>
>>> And why, for instance, the file odp_buffer.c is needed? (or, why it is
>>> not named odp_event.c?)
>>>
>>> Shall we think of
>>>
>>> events as "things that can be scheduled and can be stored in queues"
>>>
>>> and
>>>
>>> buffers as "places where data can be stored" ?
>>>
>>> Best regards,
>>>
>>> Ola D (a bit confused)
>>>
>>>
>>>
>>>> There are some lines over 80 char, since those are caused by temporary
>>>> event <-> buffer, packet -> event -> buffer conversions and should be
>>>> cleaned up
>>>> from the implementation anyway.
>>>>
>>>> Petri Savolainen (15):
>>>>    api: event: Add odp_event_t
>>>>    api: event: odp_schedule and odp_queue_enq
>>>>    api: event: schedule_multi and queue_enq_multi
>>>>    api: event: odp_queue_deq
>>>>    api: event: odp_queue_deq_multi
>>>>    api: buffer: Removed odp_buffer_type
>>>>    api: packet: Removed odp_packet_to_buffer
>>>>    api: packet: Removed odp_packet_from_buffer
>>>>    api: timer: Use odp_event_t instead of odp_buffer_t
>>>>    api: crypto: Use odp_event_t instead of odp_buffer_t
>>>>    linux-generic: crypto: Use packet alloc for packet
>>>>    api: buffer_pool: Rename odp_buffer_pool.h to odp_pool.h
>>>>    api: pool: Rename pool params and remove buffer types
>>>>    api: pool: Rename odp_buffer_pool_ to odp_pool_
>>>>    api: config: Renamed ODP_CONFIG_BUFFER_POOLS
>>>>
>>>>   example/generator/odp_generator.c                  |  38 ++---
>>>>   example/ipsec/odp_ipsec.c                          |  70 ++++----
>>>>   example/ipsec/odp_ipsec_cache.c                    |   4 +-
>>>>   example/ipsec/odp_ipsec_cache.h                    |   2 +-
>>>>   example/ipsec/odp_ipsec_loop_db.c                  |   2 +-
>>>>   example/ipsec/odp_ipsec_loop_db.h                  |  12 +-
>>>>   example/ipsec/odp_ipsec_stream.c                   |  20 +--
>>>>   example/ipsec/odp_ipsec_stream.h                   |   2 +-
>>>>   example/l2fwd/odp_l2fwd.c                          |  28 +--
>>>>   example/packet/odp_pktio.c                         |  28 +--
>>>>   example/timer/odp_timer_test.c                     |  64 +++----
>>>>   platform/linux-generic/Makefile.am                 |   4 +-
>>>>   platform/linux-generic/include/api/odp.h           |   3 +-
>>>>   platform/linux-generic/include/api/odp_buffer.h    |  40 +++--
>>>>   .../linux-generic/include/api/odp_buffer_pool.h    | 177
>>>> -------------------
>>>>   .../linux-generic/include/api/odp_classification.h |   2 +-
>>>>   platform/linux-generic/include/api/odp_config.h    |   4 +-
>>>>   platform/linux-generic/include/api/odp_crypto.h    |  16 +-
>>>>   platform/linux-generic/include/api/odp_event.h     |  59 +++++++
>>>>   platform/linux-generic/include/api/odp_packet.h    |  29 ++--
>>>>   platform/linux-generic/include/api/odp_packet_io.h |   4 +-
>>>>   .../linux-generic/include/api/odp_platform_types.h |  10 +-
>>>>   platform/linux-generic/include/api/odp_pool.h      | 189
>>>> +++++++++++++++++++++
>>>>   platform/linux-generic/include/api/odp_queue.h     |  32 ++--
>>>>   platform/linux-generic/include/api/odp_schedule.h  |  32 ++--
>>>>   platform/linux-generic/include/api/odp_timer.h     |  56 +++---
>>>>   .../linux-generic/include/odp_buffer_inlines.h     |   6 +-
>>>>   .../linux-generic/include/odp_buffer_internal.h    |  20 ++-
>>>>   .../include/odp_buffer_pool_internal.h             |  22 +--
>>>>   .../linux-generic/include/odp_crypto_internal.h    |   2 +-
>>>>   .../linux-generic/include/odp_packet_internal.h    |   8 +-
>>>>   platform/linux-generic/include/odp_packet_socket.h |  10 +-
>>>>   platform/linux-generic/odp_buffer.c                |  12 +-
>>>>   platform/linux-generic/odp_buffer_pool.c           | 133
>>>> +++++++--------
>>>>   platform/linux-generic/odp_crypto.c                |  29 ++--
>>>>   platform/linux-generic/odp_event.c                 |  19 +++
>>>>   platform/linux-generic/odp_packet.c                |  34 ++--
>>>>   platform/linux-generic/odp_packet_io.c             |  14 +-
>>>>   platform/linux-generic/odp_packet_socket.c         |  10 +-
>>>>   platform/linux-generic/odp_queue.c                 |  18 +-
>>>>   platform/linux-generic/odp_schedule.c              |  48 +++---
>>>>   platform/linux-generic/odp_timer.c                 |  35 ++--
>>>>   test/performance/odp_scheduling.c                  | 105 +++++++-----
>>>>   43 files changed, 806 insertions(+), 646 deletions(-)
>>>>   delete mode 100644 platform/linux-generic/
>>>> include/api/odp_buffer_pool.h
>>>>   create mode 100644 platform/linux-generic/include/api/odp_event.h
>>>>   create mode 100644 platform/linux-generic/include/api/odp_pool.h
>>>>   create mode 100644 platform/linux-generic/odp_event.c
>>>>
>>>>
>>>
>>> _______________________________________________
>>> lng-odp mailing list
>>> [email protected]
>>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>>
>>
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to