On Tue, Mar 24, 2015 at 3:38 PM, Ola Liljedahl <[email protected]> wrote: > On 24 March 2015 at 13:57, Maxim Uvarov <[email protected]> wrote: >> >> On 03/23/15 17:42, Petri Savolainen wrote: >>> >>> + entry->s.cls_ena = 1; /* TODO: disable cls by default */ >> >> All todos in that patch have to be doxygen /*@todo
I think we should try and capture all of the unwritten rules into a patch submission guide, including the rule about TODOs. > > vim doesn't highlight /* @todo */ but it highlights /* TODO */ > > To me, it is more important that my editor highlights TODO's and FIXME's. Vim is highly customizable, you can add additional syntax highlights if you want. In my installation, I have this in my /usr/share/vim/vim74/syntax/c.vim: syn keyword cTodo contained TODO FIXME XXX But I'm not against promoting vim, I use vim everywhere, but if we have established a convention that the code should not contain TODOs not visible by doxygen (which afaik we did) then I think it's better to adapt to the rule. > >> >> Maxim. >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> http://lists.linaro.org/mailman/listinfo/lng-odp > > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp > _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
