Those are not bugs, but highlight (new branch of) work to be done. I can remove word “TODO”, if it’s more appropriate. Anyway, I’d rather send a patch per day (with some TODO comments), than accumulate large patch series over couple of weeks (without any TODOs).
-Petri From: ext Mike Holmes [mailto:[email protected]] Sent: Tuesday, March 24, 2015 4:10 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: ext Maxim Uvarov; [email protected] Subject: Re: [lng-odp] [PATCH 1/4] linux-generic: scheduler: restructured queue and pktio integration I consider any todo a bug - unless it is tracked it will likely not get fixed, clearly the the author knows there is a flaw at submission time. We have been fairly good ensuring that all todos contain a bug ID, multiple todo may point at the same bug ID if appropriate - some of those todo bug IDs have been elevated to JIRA tasks to schedule closing them. Ciprain re capturing the patch rules - we have a patch guide in the root dir called CONTRIBUTING, fancy adding a paragraph to it :) ? On 24 March 2015 at 10:00, Savolainen, Petri (Nokia - FI/Espoo) <[email protected]<mailto:[email protected]>> wrote: These are implementation related TODOs. In general, we should not doxygen document implementation, only the API. Doxygen generates API documentation. -Petri > -----Original Message----- > From: > [email protected]<mailto:[email protected]> > [mailto:lng-odp-<mailto:lng-odp-> > [email protected]<mailto:[email protected]>] On Behalf Of ext > Maxim Uvarov > Sent: Tuesday, March 24, 2015 2:57 PM > To: [email protected]<mailto:[email protected]> > Subject: Re: [lng-odp] [PATCH 1/4] linux-generic: scheduler: restructured > queue and pktio integration > > On 03/23/15 17:42, Petri Savolainen wrote: > > + entry->s.cls_ena = 1; /* TODO: disable cls by default */ > All todos in that patch have to be doxygen /*@todo > > Maxim. > > _______________________________________________ > lng-odp mailing list > [email protected]<mailto:[email protected]> > http://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list [email protected]<mailto:[email protected]> http://lists.linaro.org/mailman/listinfo/lng-odp -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org<http://www.linaro.org/> │ Open source software for ARM SoCs
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
