Tested new check patch and in general it's more strict for code style
and most of warnings are reasonable.
Also now it will generate following checks:
CHECK: Comparison to NULL could be written "new_udat"
#130: FILE: test/validation/odp_packet.c:562:
+ CU_ASSERT(new_udat != NULL);
I.e. checkpatch will expect syntax CU_ASSERT(new_date). In odp we can
follow new checkpatch or I can comment out that check.
Also might be reasonable to add internal odp check for invalid handles
somehow. (i.e. check that pool_hdl = 0 is wrong it has to be pool_hdl =
ODP_POOL_INVALID and etc.).
Best regards,
Maxim.
On 05/13/2015 13:49, Maxim Uvarov wrote:
Update checkpatch. Add our local fixes. Plus fix lenght limit for log functions.
Thanks,
Maxim.
Maxim Uvarov (2):
checkpatch: update to linux 4.1 rc-3
checkpatch: remove cunit warnings
Taras Kondratiuk (1):
checkpatch: remove line length limit for odp log functions
scripts/checkpatch.pl | 2513 ++++++++++++++++++++++++++++++++++++++++++-------
1 file changed, 2183 insertions(+), 330 deletions(-)
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp
