Not completely understood your concern.If you are concerned about the coverage of "odp_queue_sched_type" API then odp_queue unit can be extended to create schedule type queue and add "odp_queue_sched_type" API coverage. But in any case, We should remove the odp_queue_sched_type() call on pooled queues.
From: Mike Holmes <[email protected]> Sent: Tuesday, May 26, 2015 8:14 PM To: Jacob, Jerin Cc: lng-odp Subject: Re: [lng-odp] [PATCH] validation: queue: schedule parameters are not valid for poll type queue If this is not a valid sunny day test, should we rename it and retain it as a valid test case for passing an non valid params ? On 22 May 2015 at 07:43, Jerin Jacob <[email protected]> wrote: Signed-off-by: Jerin Jacob <[email protected]> --- test/validation/odp_queue.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/test/validation/odp_queue.c b/test/validation/odp_queue.c index 5123939..01a704c 100644 --- a/test/validation/odp_queue.c +++ b/test/validation/odp_queue.c @@ -45,24 +45,18 @@ static void test_odp_queue_sunnyday(void) odp_buffer_t buf; odp_event_t ev; odp_pool_t msg_pool; - odp_queue_param_t param; odp_event_t *pev_tmp; int i, deq_ret, ret; int nr_deq_entries = 0; int max_iteration = CONFIG_MAX_ITERATION; void *prtn = NULL; - memset(¶m, 0, sizeof(param)); - param.sched.sync = ODP_SCHED_SYNC_NONE; - queue_creat_id = odp_queue_create("test_queue", - ODP_QUEUE_TYPE_POLL, ¶m); + ODP_QUEUE_TYPE_POLL, NULL); CU_ASSERT(ODP_QUEUE_INVALID != queue_creat_id); CU_ASSERT_EQUAL(ODP_QUEUE_TYPE_POLL, odp_queue_type(queue_creat_id)); - CU_ASSERT_EQUAL(ODP_SCHED_SYNC_NONE, - odp_queue_sched_type(queue_creat_id)); queue_id = odp_queue_lookup("test_queue"); CU_ASSERT_EQUAL(queue_creat_id, queue_id); -- 2.1.0 _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org │ Open source software for ARM SoCs _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
