Merged,
Maxim.
On 06/02/15 20:44, Mike Holmes wrote:
I dont have any objections.
On 2 June 2015 at 11:19, Maxim Uvarov <[email protected]
<mailto:[email protected]>> wrote:
Patch looks good. Mike I think you don't have objections to apply
it, right?
Maxim.
On 05/28/15 09:24, Jerin Jacob wrote:
On Wed, May 27, 2015 at 07:38:26AM -0400, Mike Holmes wrote:
On 27 May 2015 at 00:17, Jacob, Jerin
<[email protected]
<mailto:[email protected]>>
wrote:
Not completely understood your concern.If you are
concerned about the
coverage of "odp_queue_sched_type" API
then odp_queue unit can be extended to create schedule
type queue and add
"odp_queue_sched_type" API coverage.
But in any case, We should remove the
odp_queue_sched_type() call on
pooled queues.
My thought was that we have very poor sunny day coverage,
and we should
extend that and ensure such cases are accurate as you
propose. But in
addition calling the API in other combinations actually
helps define the
APIs behavior. In this case the current test is not
correct but may add
value the the testing ?
I have not looked in detail - just asking if there was
merit to keeping a
copy of this as a "bad" test.
IMO, No merit in keeping the bad test.
From: Mike Holmes <[email protected]
<mailto:[email protected]>>
Sent: Tuesday, May 26, 2015 8:14 PM
To: Jacob, Jerin
Cc: lng-odp
Subject: Re: [lng-odp] [PATCH] validation: queue:
schedule parameters are
not valid for poll type queue
If this is not a valid sunny day test, should we
rename it and retain it
as a valid test case for passing an non valid params ?
On 22 May 2015 at 07:43, Jerin Jacob
<[email protected]
<mailto:[email protected]>>
wrote:
Signed-off-by: Jerin Jacob
<[email protected]
<mailto:[email protected]>>
---
test/validation/odp_queue.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/test/validation/odp_queue.c
b/test/validation/odp_queue.c
index 5123939..01a704c 100644
--- a/test/validation/odp_queue.c
+++ b/test/validation/odp_queue.c
@@ -45,24 +45,18 @@ static void
test_odp_queue_sunnyday(void)
odp_buffer_t buf;
odp_event_t ev;
odp_pool_t msg_pool;
- odp_queue_param_t param;
odp_event_t *pev_tmp;
int i, deq_ret, ret;
int nr_deq_entries = 0;
int max_iteration = CONFIG_MAX_ITERATION;
void *prtn = NULL;
- memset(¶m, 0, sizeof(param));
- param.sched.sync = ODP_SCHED_SYNC_NONE;
-
queue_creat_id = odp_queue_create("test_queue",
- ODP_QUEUE_TYPE_POLL, ¶m);
+ ODP_QUEUE_TYPE_POLL, NULL);
CU_ASSERT(ODP_QUEUE_INVALID != queue_creat_id);
CU_ASSERT_EQUAL(ODP_QUEUE_TYPE_POLL,
odp_queue_type(queue_creat_id));
- CU_ASSERT_EQUAL(ODP_SCHED_SYNC_NONE,
- odp_queue_sched_type(queue_creat_id));
queue_id = odp_queue_lookup("test_queue");
CU_ASSERT_EQUAL(queue_creat_id, queue_id);
--
2.1.0
_______________________________________________
lng-odp mailing list
[email protected] <mailto:[email protected]>
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org │ Open source software for ARM SoCs
--
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source
software for ARM SoCs
_______________________________________________
lng-odp mailing list
[email protected] <mailto:[email protected]>
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp
