On 9 June 2015 at 04:08, Nicolas Morey-Chaisemartin <[email protected]>
wrote:

> On some systems, char is mapped to unsigned char which causes gcc to issue
> this warning:
> test/validation/ver_abt_log_dbg/odp_system.c:23:7: error: array subscript
> has type ‘char’ [-Werror=char-subscripts]
> Manually casting from char to int should fix issue on both (signed or
> unsigned) types of system
>
> Signed-off-by: Nicolas Morey-Chaisemartin <[email protected]>
>

Reviewed-by: Mike Holmes <[email protected]>


> ---
>  test/validation/ver_abt_log_dbg/odp_system.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/validation/ver_abt_log_dbg/odp_system.c
> b/test/validation/ver_abt_log_dbg/odp_system.c
> index 1a40957..5185a71 100644
> --- a/test/validation/ver_abt_log_dbg/odp_system.c
> +++ b/test/validation/ver_abt_log_dbg/odp_system.c
> @@ -19,7 +19,7 @@ static void test_odp_version_numbers(void)
>                 sizeof(version_string)-1);
>
>         while (*s) {
> -               if (isdigit(*s) || (strncmp(s, ".", 1) == 0)) {
> +               if (isdigit((int)*s) || (strncmp(s, ".", 1) == 0)) {
>                         char_ok = 1;
>                         s++;
>                 } else {
> _______________________________________________
> lng-odp mailing list
> [email protected]
> https://lists.linaro.org/mailman/listinfo/lng-odp
>



-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to