We updated checkpatch so older code may not be compliant now, we always need a patch to pass the current checkpatch.
The new checkpatch now generates these warning s in the old code https://ci.linaro.org/job/odp-api-style-check/label=build/466/console On 9 June 2015 at 08:38, Nicolas Morey-Chaisemartin <[email protected]> wrote: > One question about this: > > I added spaces between the string and the PRIx32 macro because checkpatch > generated a warning when I didn't. > However most source files I've seen do not add spaces. > > What is your preferred way? Does check patch needs to be updated to remove > this specific warning, or should all the PRI.NN macros be padded with > spaces? > > > On 06/09/2015 10:06 AM, Nicolas Morey-Chaisemartin wrote: > > Signed-off-by: Nicolas Morey-Chaisemartin <[email protected]> > > --- > > test/performance/odp_pktio_perf.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/test/performance/odp_pktio_perf.c > b/test/performance/odp_pktio_perf.c > > index 17975bf..6d9b66c 100644 > > --- a/test/performance/odp_pktio_perf.c > > +++ b/test/performance/odp_pktio_perf.c > > @@ -650,8 +650,10 @@ static int run_test(void) > > printf("\tTransmit workers: \t%d\n", > odp_cpumask_count(&txmask)); > > printf("\tReceive workers: \t%d\n", > odp_cpumask_count(&rxmask)); > > printf("\tDuration (seconds): \t%d\n", gbl_args->args.duration); > > - printf("\tTransmit batch length:\t%d\n", > gbl_args->args.tx_batch_len); > > - printf("\tReceive batch length: \t%d\n", > gbl_args->args.rx_batch_len); > > + printf("\tTransmit batch length:\t%" PRIu32 "\n", > > + gbl_args->args.tx_batch_len); > > + printf("\tReceive batch length: \t%" PRIu32 "\n", > > + gbl_args->args.rx_batch_len); > > printf("\tPacket receive method:\t%s\n", > > gbl_args->args.schedule ? "schedule" : "poll"); > > printf("\tInterface(s): \t"); > > _______________________________________________ > > lng-odp mailing list > > [email protected] > > https://lists.linaro.org/mailman/listinfo/lng-odp > > > _______________________________________________ > lng-odp mailing list > [email protected] > https://lists.linaro.org/mailman/listinfo/lng-odp > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
