When I added that print I expected that person who executed test for
specific pktio can verify that
printed mac address is the same as read pktio (device). With removing
that print there will be no
way to prove that right mac addr was returned.
Maxim.
On 09/04/15 12:55, Stuart Haslam wrote:
To avoid cluttering the test output, unit tests should not print directly
to stdout.
Signed-off-by: Stuart Haslam <[email protected]>
---
test/validation/pktio/pktio.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c
index 512a77c..50cd901 100644
--- a/test/validation/pktio/pktio.c
+++ b/test/validation/pktio/pktio.c
@@ -563,15 +563,9 @@ void pktio_test_mac(void)
pktio = create_pktio(iface_name[0], ODP_QUEUE_TYPE_SCHED, 0);
- printf("testing mac for %s\n", iface_name[0]);
-
mac_len = odp_pktio_mac_addr(pktio, mac_addr, sizeof(mac_addr));
CU_ASSERT(ODPH_ETHADDR_LEN == mac_len);
- printf(" %X:%X:%X:%X:%X:%X ",
- mac_addr[0], mac_addr[1], mac_addr[2],
- mac_addr[3], mac_addr[4], mac_addr[5]);
-
/* Fail case: wrong addr_size. Expected <0. */
mac_len = odp_pktio_mac_addr(pktio, mac_addr, 2);
CU_ASSERT(mac_len < 0);
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp
