On 09/07/15 17:35, Stuart Haslam wrote:
On Mon, Sep 07, 2015 at 02:05:29PM +0300, Maxim Uvarov wrote:
When I added that print I expected that person who executed test for
specific pktio can verify that
printed mac address is the same as read pktio (device).
Hrm, I've never done that.
With removing that print there will be no
way to prove that right mac addr was returned.
Maxim.
I don't think the validation tests should expect visual inspection of
the output. We could test the correct MAC is returned by using it as
the destination address with promiscuous mode disabled.
we also can pass correct mac in pktio_env as device names and inside
test expect that they match. But with promisc mode it looks more
interesting.
Maxim.
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp
