I have just reviewed the all series. As a side note though, I thing a MACRO called ODP_TEST_OVERLOAD(test_func, new_test_func) should be defined if a given test function should be "replaced") using the update function. The TEST_INFO macro would not be able to be used as, for this macro, the name of the test matches the name of the function and functions cannot be overloaded in C. I think that could be done in another patch, though. (hence my reviews)
Do you agree Stuart? On 14 October 2015 at 11:28, Stuart Haslam <[email protected]> wrote: > This series adds the ability to skip individual test cases either at > compile time or conditionally at run time. There's no functional change > since none of the existing tests use this facility. > > There are a few checkpatch warnings about camel case due to the names > of CUnit structure elements, but with those ignored it's clean. > > Changes in v2; > > - Changes following Christophe's comments; rework cunit_test_update() > somewhat and make a few associated changes, fix copy/paste error in > implementers guide and a few other tidy ups, updated README. > > Changes in v3; > > - More documentation following review. > > Stuart Haslam (5): > validation: add ability to mark tests inactive > validation: add odp_cunit_update() to modify registered tests > doc: implementers-guide: update names of test module libraries > doc: implementers-guide: update section on skipping tests > validation: update README > > doc/implementers-guide/implementers-guide.adoc | 108 +++++++--- > test/validation/README | 45 +--- > test/validation/buffer/buffer.c | 27 +-- > test/validation/buffer/buffer.h | 6 +- > test/validation/classification/classification.c | 11 +- > test/validation/classification/classification.h | 8 +- > .../classification/odp_classification_basic.c | 20 +- > .../classification/odp_classification_tests.c | 16 +- > .../classification/odp_classification_testsuites.h | 7 +- > test/validation/common/odp_cunit_common.c | 234 > ++++++++++++++++++++- > test/validation/common/odp_cunit_common.h | 50 ++++- > test/validation/cpumask/cpumask.c | 53 ++--- > test/validation/cpumask/cpumask.h | 6 +- > test/validation/crypto/crypto.c | 22 +- > test/validation/crypto/crypto.h | 6 +- > test/validation/crypto/odp_crypto_test_inp.c | 14 +- > test/validation/crypto/odp_crypto_test_inp.h | 4 +- > test/validation/errno/errno.c | 19 +- > test/validation/errno/errno.h | 6 +- > test/validation/init/init.c | 66 ++++-- > test/validation/init/init.h | 14 +- > test/validation/packet/packet.c | 53 ++--- > test/validation/packet/packet.h | 6 +- > test/validation/pktio/pktio.c | 62 +++--- > test/validation/pktio/pktio.h | 6 +- > test/validation/pool/pool.c | 23 +- > test/validation/pool/pool.h | 6 +- > test/validation/queue/queue.c | 20 +- > test/validation/queue/queue.h | 6 +- > test/validation/random/random.c | 19 +- > test/validation/random/random.h | 6 +- > test/validation/scheduler/scheduler.c | 79 +++---- > test/validation/scheduler/scheduler.h | 6 +- > test/validation/shmem/shmem.c | 19 +- > test/validation/shmem/shmem.h | 6 +- > test/validation/synchronizers/synchronizers.c | 88 ++++---- > test/validation/synchronizers/synchronizers.h | 16 +- > test/validation/system/system.c | 31 +-- > test/validation/system/system.h | 6 +- > test/validation/thread/thread.c | 55 ++--- > test/validation/thread/thread.h | 6 +- > test/validation/time/time.c | 23 +- > test/validation/time/time.h | 6 +- > test/validation/timer/timer.c | 25 ++- > test/validation/timer/timer.h | 6 +- > 45 files changed, 846 insertions(+), 475 deletions(-) > > -- > 2.1.1 > >
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
