On 19 September 2016 at 10:20, Bill Fischofer <bill.fischo...@linaro.org> wrote:
> On Mon, Sep 19, 2016 at 2:50 AM, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolai...@nokia-bell-labs.com> wrote: > > > Ping. V1 was reviewed 6 days ago. Changes from v1 to v2 are trivial. > > > > I thought my review would be propagated to v2. > I think we should make it policy that we always add the reviewed by again to save any ambiguity. It is possible that a V2 breaks something new and then if Maxim moved the review forward as a paperwork exercise only, the onus is on him to really re review it to be sure it still works. > > > > > > -Petri > > > > > > > -----Original Message----- > > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > > Petri > > > Savolainen > > > Sent: Wednesday, September 14, 2016 3:11 PM > > > To: lng-odp@lists.linaro.org > > > Subject: Suspected SPAM - [lng-odp] [PATCH v2] linux-gen: build: > > de-couple > > > abi compatibility from shared lib > > > > > > Building ABI compatible or shared library are two different > > > targets. A shared library may be used also without ABI > > > compatibility. A new --enable-abi-compat configuration option > > > is introduced. By default libraries are not built in ABI compat > > > mode to enable function inlining. There is a noticeable > > > performance difference when e.g. odp_atomic_xxx calls > > > are not inlined. > > > > > > Signed-off-by: Petri Savolainen <petri.savolai...@nokia.com> > > > > Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > > > > > --- > > > > > > v2: > > > * ABI compat enabled by default > > > * print static/shared/abi_compat selection in config results > > > * added missing header file include guards > > > > > > -- Mike Holmes Program Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
