Ping. Bill reviewed this on Monday.

From: Bill Fischofer [mailto:bill.fischo...@linaro.org] 
Sent: Monday, September 19, 2016 5:20 PM
To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com>
Cc: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility 
from shared lib



On Mon, Sep 19, 2016 at 2:50 AM, Savolainen, Petri (Nokia - FI/Espoo) 
<petri.savolai...@nokia-bell-labs.com> wrote:
Ping. V1 was reviewed 6 days ago. Changes from v1 to v2 are trivial.

I thought my review would be propagated to v2.
 

-Petri


> -----Original Message-----
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri
> Savolainen
> Sent: Wednesday, September 14, 2016 3:11 PM
> To: lng-odp@lists.linaro.org
> Subject: Suspected SPAM - [lng-odp] [PATCH v2] linux-gen: build: de-couple
> abi compatibility from shared lib
>
> Building ABI compatible or shared library are two different
> targets. A shared library may be used also without ABI
> compatibility. A new --enable-abi-compat configuration option
> is introduced. By default libraries are not built in ABI compat
> mode to enable function inlining. There is a noticeable
> performance difference when e.g. odp_atomic_xxx calls
> are not inlined.
>
> Signed-off-by: Petri Savolainen <petri.savolai...@nokia.com>

Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org>
 
> ---
>
> v2:
>   * ABI compat enabled by default
>   * print static/shared/abi_compat selection in config results
>   * added missing header file include guards
>

Reply via email to