Le 12/06/2016 à 10:17 PM, Maxim Uvarov a écrit : > On 12/06/16 23:37, Mike Holmes wrote: >> On 6 December 2016 at 12:08, Nicolas Morey-Chaisemartin >> <nmo...@kalray.eu> wrote: >>> Signed-off-by: Nicolas Morey-Chaisemartin <nmo...@kalray.eu> >>> --- >>> helper/Makefile.am | 6 +++--- >>> helper/test/Makefile.am | 6 +++--- >>> 2 files changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/helper/Makefile.am b/helper/Makefile.am >>> index d09d900..c75db00 100644 >>> --- a/helper/Makefile.am >>> +++ b/helper/Makefile.am >>> @@ -1,7 +1,7 @@ >>> include $(top_srcdir)/platform/@with_platform@/Makefile.inc >>> >>> pkgconfigdir = $(libdir)/pkgconfig >>> -pkgconfig_DATA = $(top_builddir)/pkgconfig/libodphelper-linux.pc >>> +pkgconfig_DATA = $(top_builddir)/pkgconfig/libodphelper@ODP_LIB_FLAVOR@.pc >> Why would the helpers be tied to the implementation being built ? They >> should be agnostic and depend on the OS >> I think the helpers are broken or we need an alternative to linux.c in >> there, perhaps a odp/helpers/platform/linux/linux.c and >> odp/helpers/platform/mpaa/linux.c >> > > Nicolas, do you have modification in helpers? We checked that > linux-generic and odp-dpdk platform have the same source code for > helpers. And we are doing efforts to make it the same. > > Maxim. At this moment we have a different linux.c for our own thread/process implementation. But I think I'll have to change some things in the hashtable helper to handle our lack of cache coherency.
Nicolas
