On 30 December 2016 at 12:01, Savolainen, Petri (Nokia - FI/Espoo) < [email protected]> wrote:
> > > +=== Known Issues > > > + > > > +==== https://bugs.linaro.org/show_bug.cgi?id=2765[Bug 2765] > > > +The fixed storage overhead for supporting the new pool structures is > > large > > > +(over a quarter of a gigabyte). This may have an impact on smaller > > systems. > > > + > > > > > > I think we need merge this patch before release. Patch itself is > > reasonable and I think it can to go. But it will be good to get Petris > > feedback on answer on his comment. > > > > Maxim. > > What feedback you'd need? > > From API point of view only difference should be ipsec.h. Currently 'next' > is missing couple of name length modifications from 'api-next' (api: unify > ODP_*_NAME_LEN specifications, api: move ODP_*_NAME_LEN definitions from > API to implementation). Those should be trivial additions to 'next' and > would make the release more consistent (as all name lengths would be > defined the same way). > > Ok, I will take these commits also. > After that merge, we should be ready for the release. E.g. the above bug > (large storage overhead) is not blocking since it matter only small systems > and a user can work around it by using smaller pool defines in config.h. > > Feedback on that patch, because you added comment. Usually new users do not fix anything anywhere. They even don't know what needs to be fixed. And they can stop looking to the project is it does not work for some reasons. > I'd like to see release happening sooner than later, so that the > (unnecessary) large gap closes between api-next and master. > > -Petri > > I think everybody agree with it. But it's holidays and we need people to do release things. Maxim.
