On 5 April 2017 at 01:21, Dmitry Eremin-Solenikov <[email protected]> wrote: > On 05.04.2017 00:25, Brian Brooks wrote: >> On 04/04 23:23:33, Dmitry Eremin-Solenikov wrote: >>> On 04.04.2017 22:25, Maxim Uvarov wrote: >>>> it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD >>>> defined and one for not. >>> >>> Seconding that. At least LLDSCD and non-LLDSCD code should not be >>> interleaved. >> >> Can you explain your judgement? > > Consider reading two intermixed books of technical recipes. It is just > my opinion, but I'd prefer to have two separate code blocks: one for > LLDSCD, one for non-LLDSCD cases. In this case, it is two recipes for baking the *same* cake. We think it is useful to be able to easily compare the recipes. Each function can be considered a separate code block, it's not like we are mixing recipes line by line.
> > -- > With best wishes > Dmitry
