On 05.04.2017 21:36, Ola Liljedahl wrote: > On 5 April 2017 at 17:33, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> On 05.04.2017 17:40, Ola Liljedahl wrote: >>> On 5 April 2017 at 14:20, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >>>> On 04/05/17 01:46, Ola Liljedahl wrote: >>>>> On 4 April 2017 at 21:25, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >>>>>> it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD >>>>> "better"? In what way? >>> Please respond to the question. If you claim something is "better", >>> you must be able to explain *why* it is better. >>> >>> *We* have explained why we think it is better to keep both >>> implementations in the same file, close to each other. I think Brian's >>> explanation was very good. >> >> Because it allows one to overview a complete implementation at once >> instead of switching between two different modes. > That's a good argument as well. It doesn't mean that the > implementations should live in separate files. > > We keep both implementations in the same file but avoid interleaving > the different functions (as is done now). This is actually what some > one in our team wanted.
Once you have those implementations de-interleaved, it should be easy to split them to separate files. I won't insist on that though, for me deinterleaving them would be good enough. -- With best wishes Dmitry
