Is there a way to get Github to send individual patches to the list ? ... Instead of this all-patches-in-one-mail format, with a misleading subject line (1/3).
> -----Original Message----- > From: lng-odp [mailto:[email protected]] On Behalf Of Maxim > Uvarov > Sent: Monday, April 10, 2017 3:43 PM > To: [email protected] > Subject: [lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt > unsigned > > From: Dmitry Eremin-Solenikov <[email protected]> > > It does not make sense to specify negative amount inside num_*. Make > respective fields unsigned instead. > > Signed-off-by: Dmitry Eremin-Solenikov <[email protected]> > --- > /** Email created from pull request 13 (lumag:ipsec-api) > ** https://github.com/Linaro/odp/pull/13 > ** Patch: https://github.com/Linaro/odp/pull/13.patch > ** Base sha: 38485719c028918b019c6a5fc67cf05053421c83 > ** Merge commit sha: 80f41ee9602b2b4282da8907c9d2fa78fdb6aeb8 > **/ > include/odp/api/spec/ipsec.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h > index a0ceb11..5655351 100644 > --- a/include/odp/api/spec/ipsec.h > +++ b/include/odp/api/spec/ipsec.h > @@ -920,7 +920,7 @@ typedef struct odp_ipsec_op_status_t { > */ > typedef struct odp_ipsec_op_param_t { > /** Number of packets to be processed */ > - int num_pkt; > + unsigned num_pkt; I guess unsigned could be used. Usually, we use 'int num' as it matches function return value type. > > From 330973e1c1b029f67d629159761c559f4e9060e8 Mon Sep 17 00:00:00 2001 > From: Dmitry Eremin-Solenikov <[email protected]> > Date: Mon, 10 Apr 2017 14:24:55 +0300 > Subject: [PATCH 3/3] api: ipsec: add default queue for outbound events > > If SA lookup fails for outbound IPsec packet in async mode, there is no > way to report it back to application except using default queue (which > does not exist at this moment). There's no SA lookup but application should always give valid SA handles to the implementation. So, this queue is needed for sending an error back that an invalid SA was given, right ? -Petri > > Signed-off-by: Dmitry Eremin-Solenikov <[email protected]> > --- > /** Email created from pull request 13 (lumag:ipsec-api) > ** https://github.com/Linaro/odp/pull/13 > ** Patch: https://github.com/Linaro/odp/pull/13.patch > ** Base sha: 38485719c028918b019c6a5fc67cf05053421c83 > ** Merge commit sha: 80f41ee9602b2b4282da8907c9d2fa78fdb6aeb8 > **/ > include/odp/api/spec/ipsec.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h > index 33a84ee..4e3ec16 100644 > --- a/include/odp/api/spec/ipsec.h > +++ b/include/odp/api/spec/ipsec.h > @@ -188,6 +188,13 @@ typedef struct odp_ipsec_inbound_config_t { > * Configuration options for IPSEC outbound processing > */ > typedef struct odp_ipsec_outbound_config_t { > + /** Default destination queue for IPSEC events > + * > + * When outbound SA lookup fails in the asynchronous mode, > + * resulting IPSEC events are enqueued into this queue. > + */ > + odp_queue_t default_queue; > + > /** Flags to control L3/L4 checksum insertion as part of > outbound > * packet processing. Packet must have set with valid L3/L4 > offsets. > * Checksum configuration is ignored for packets that checksum > cannot
