On 10.04.2017 16:14, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Is there a way to get Github to send individual patches to the list ? ... > Instead of this all-patches-in-one-mail format, with a misleading subject > line (1/3). > > > >> -----Original Message----- >> From: lng-odp [mailto:[email protected]] On Behalf Of Maxim >> Uvarov >> Sent: Monday, April 10, 2017 3:43 PM >> To: [email protected] >> Subject: [lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt >> unsigned >> >> From: Dmitry Eremin-Solenikov <[email protected]> >> >> It does not make sense to specify negative amount inside num_*. Make >> respective fields unsigned instead. >> >> Signed-off-by: Dmitry Eremin-Solenikov <[email protected]> >> --- >> /** Email created from pull request 13 (lumag:ipsec-api) >> ** https://github.com/Linaro/odp/pull/13 >> ** Patch: https://github.com/Linaro/odp/pull/13.patch >> ** Base sha: 38485719c028918b019c6a5fc67cf05053421c83 >> ** Merge commit sha: 80f41ee9602b2b4282da8907c9d2fa78fdb6aeb8 >> **/ >> include/odp/api/spec/ipsec.h | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h >> index a0ceb11..5655351 100644 >> --- a/include/odp/api/spec/ipsec.h >> +++ b/include/odp/api/spec/ipsec.h >> @@ -920,7 +920,7 @@ typedef struct odp_ipsec_op_status_t { >> */ >> typedef struct odp_ipsec_op_param_t { >> /** Number of packets to be processed */ >> - int num_pkt; >> + unsigned num_pkt; > > I guess unsigned could be used. Usually, we use 'int num' as it matches > function return value type.
Then shouldn't we change function return value type? I'd see this as int vs size_t argument. If the value is unsigned, then the holding type also should be unsigned, shan't it? -- With best wishes Dmitry
