> >> > >> You can have arm, arm64, mips64, etc. directories inside > >> examples/ipfrag. > > > > This does not scale in practice. If another example comes along, does > > that also need to split whatever is determined to be "arch" code into > > "arch" directories within its own folder? > > > > I recommend that this contribution be accepted without any further > change. > > From my perspective, separate arm, aarch64 and generic headers would be > sufficient, even if they are not put under separate directories. That > was just a suggestion. >
The main concern I have with this is that: ODP examples should demonstrate how ODP APIs are used to do X. In other words: "If you implement X like this with ODP APIs, your code is: * 100% portable * still good performance * clean and easy to understand / maintain" Super optimized, architecture specific implementation of X would not drive that purpose. It also leads to maintenance issues later on - a bug found and fixed on CPU arch Y does not get automatically fixed for arch Z. We are drawing a line here if embedded assembly or otherwise arch dependent code belongs to example applications. I'd say it does not, since HW abstraction is the sole purpose of ODP. -Petri
