On 1 May 2017 at 12:58, Bill Fischofer <[email protected]> wrote: > > > On Sun, Apr 30, 2017 at 11:05 PM, Honnappa Nagarahalli > <[email protected]> wrote: >> >> We talked about introducing the modular queue interface. I spent time >> re-looking at this, according to me it does not solve any issues we >> have currently. >> >> The main issue we are trying to address currently is avoiding code >> under #ifdefs and the resulting compilation combinations and testing >> those code paths. >> >> Currently, we have 3 schedulers - default, SP and iQuery - To use any >> of these, ODP needs to be configured with --enable-xxx option which in >> turn defines the compile time #defines. The current code base has code >> under these flags. Modular queue interface does not change any of >> this. > > > The key is that these #ifdefs exist only within the scheduler framework > itself (odp_schedule_if.c). The scalable scheduler should follow the same > model.
Keeping #ifdefs to this file alone does not solve the CI and testing problems. We still end up having multiple code paths. > >> >> >> I do not think there is a need to introduce a modular queue interface >> at this time. >> >> Thanks, >> Honnappa > >
