On Mon, May 1, 2017 at 4:02 PM, Honnappa Nagarahalli < [email protected]> wrote:
> On 1 May 2017 at 12:58, Bill Fischofer <[email protected]> wrote: > > > > > > On Sun, Apr 30, 2017 at 11:05 PM, Honnappa Nagarahalli > > <[email protected]> wrote: > >> > >> We talked about introducing the modular queue interface. I spent time > >> re-looking at this, according to me it does not solve any issues we > >> have currently. > >> > >> The main issue we are trying to address currently is avoiding code > >> under #ifdefs and the resulting compilation combinations and testing > >> those code paths. > >> > >> Currently, we have 3 schedulers - default, SP and iQuery - To use any > >> of these, ODP needs to be configured with --enable-xxx option which in > >> turn defines the compile time #defines. The current code base has code > >> under these flags. Modular queue interface does not change any of > >> this. > > > > > > The key is that these #ifdefs exist only within the scheduler framework > > itself (odp_schedule_if.c). The scalable scheduler should follow the same > > model. > > Keeping #ifdefs to this file alone does not solve the CI and testing > problems. We still end up having multiple code paths. > As long as scheduler selection is a configure-time option rather than an odp_init_global()-time selection that will be the case. Something we should discuss once the basic scalable scheduler is in place. Since the hope is that this scheduler will be so good it will be the default scheduler for odp-cloud that flexibility presumably will be less important. Configure time selections are less of an issue in the embedded environment which is customizing things anyway. > > > >> > >> > >> I do not think there is a need to introduce a modular queue interface > >> at this time. > >> > >> Thanks, > >> Honnappa > > > > >
