> -----Original Message----- > From: Honnappa Nagarahalli [mailto:[email protected]] > Sent: Wednesday, May 24, 2017 6:56 AM > To: Savolainen, Petri (Nokia - FI/Espoo) <[email protected]> > Cc: Brian Brooks <[email protected]>; [email protected]; Ola > Liljedahl <[email protected]> > Subject: Re: [lng-odp] [API-NEXT PATCH v6 1/6] test: odp_sched_latency: > misc improvements > > On 23 May 2017 at 01:52, Savolainen, Petri (Nokia - FI/Espoo) > <[email protected]> wrote: > > > > > >> -----Original Message----- > >> From: lng-odp [mailto:[email protected]] On Behalf Of > Brian > >> Brooks > >> Sent: Tuesday, May 23, 2017 1:28 AM > >> To: [email protected] > >> Cc: Ola Liljedahl <[email protected]> > >> Subject: [lng-odp] [API-NEXT PATCH v6 1/6] test: odp_sched_latency: > misc > >> improvements > >> > >> Increase TEST_ROUNDS for all schedulers except SP for more > deterministic > >> test results. SP is too slow to handle the increased running time. > >> > >> Use an explicit scheduling group to inform the scheduler of the threads > >> that will join the group. > >> > >> Add a timeout to the schedule call for draining queues. > >> > >> Signed-off-by: Brian Brooks <[email protected]> > >> Signed-off-by: Ola Liljedahl <[email protected]> > >> --- > >> test/common_plat/performance/odp_sched_latency.c | 62 > >> ++++++++++++++++++++++++ > >> 1 file changed, 62 insertions(+) > >> > >> diff --git a/test/common_plat/performance/odp_sched_latency.c > >> b/test/common_plat/performance/odp_sched_latency.c > >> index 026f2f6c..3fd969ca 100644 > >> --- a/test/common_plat/performance/odp_sched_latency.c > >> +++ b/test/common_plat/performance/odp_sched_latency.c > >> @@ -28,7 +28,13 @@ > >> #define MAX_WORKERS 64 /**< Maximum number of worker > >> threads */ > >> #define MAX_QUEUES 4096 /**< Maximum number of queues > >> */ > >> #define EVENT_POOL_SIZE (1024 * 1024) /**< Event pool size */ > >> + > >> +#ifdef ODP_SCHEDULE_SP > >> #define TEST_ROUNDS (4 * 1024 * 1024) /**< Test rounds for each > >> thread */ > >> +#else > >> +#define TEST_ROUNDS (32 * 1024 * 1024) /**< Test rounds for each > >> thread */ > >> +#endif > > > > > > Cannot do this. ODP_SCHEDULE_SP is not an ODP API definition - it cannot > be used in an application. Applications must be written against the API > spec. This code would not even build on any other implementation than odp- > linux (and maybe odp-dpdk which copies lots of odp-linux code). > > > > This is a test case. We want to run for more iterations. > Unfortunately, running SP scheduler for more number of iterations > causes the test case to take a lot of time. >
It's an ODP application. No matter which is the purpose of the application, it must use ODP API correctly. All our applications are examples of how to use ODP API, and we do not want to give bad examples. > Why this code would not build on other implementation. If > ODP_SCHEDULE_SP is not defined, then TEST_ROUNDS would get defined to > higher number of iterations. I was apparently thinking of #if ODP_SCHEDULE_SP. Anyway, this definition is not part of API and thus must not be used by any application. -Petri
