> -----Original Message----- > From: Honnappa Nagarahalli [mailto:[email protected]] > Sent: Wednesday, May 24, 2017 6:59 AM > To: Savolainen, Petri (Nokia - FI/Espoo) <[email protected]> > Cc: Brian Brooks <[email protected]>; [email protected]; Ola > Liljedahl <[email protected]> > Subject: Re: [lng-odp] [API-NEXT PATCH v6 3/6] Add arch/ files > > On 23 May 2017 at 02:10, Savolainen, Petri (Nokia - FI/Espoo) > <[email protected]> wrote: > >> diff --git a/platform/linux-generic/arch/powerpc/odp_cpu.h > >> b/platform/linux-generic/arch/powerpc/odp_cpu.h > >> new file mode 100644 > >> index 00000000..e118e709 > >> --- /dev/null > >> +++ b/platform/linux-generic/arch/powerpc/odp_cpu.h > >> @@ -0,0 +1,10 @@ > >> +/* Copyright (c) 2017, Linaro Limited > >> + * All rights reserved. > >> + * > >> + * SPDX-License-Identifier: BSD-3-Clause > >> + */ > >> + > >> +#ifndef ODP_POWERPC_CPU_H_ > >> +#define ODP_POWERPC_CPU_H_ > >> + > >> +#endif > > > > > > Does this patch break build for all other archs but arm and x86? > Shouldn't you do the same (dummy) definitions for all architectures, as > you do for x86? > > > > Odp-linux should be usable in any system that runs Linux. It's not > practical to test on every arch, but we should always offer the default > code path that builds and should work fine on any arch. For example, I did > cross compile my latest x86 specific changes for PowerPC to see that a > non-x86 path also builds. > > > > We do not have the environment to compile for PowerPC or MIPS. Even if > we write dummy functions, we will not be able to compile the code for > those targets. During our earlier discussions, there was an agreement > that we will not do this for PowerPC or MIPS. Respective arch owners > have to create those functions.
ODP dependencies file have some instructions for cross compiling. With Ubuntu you just need to install some extra packages. E.g. sudo apt-get install gcc-powerpc-linux-gnu So, you have the environment to build for e.g. PowerPC. Since odp-linux is for everybody (not only x86 and arm), you must not break the build for others. You may offer the minimal support, dummy functions, something that is functionally correct but not optimized - but you must not break the build. -Petri
