> -----Original Message----- > From: Dmitry Eremin-Solenikov [mailto:[email protected]] > Sent: Wednesday, May 31, 2017 4:18 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <[email protected]>; > Github ODP bot <[email protected]>; [email protected] > Subject: Re: [lng-odp] [PATCH API-NEXT v2 16/20] linux-generic: packet: > add functions to optimize memset and memcmp paths > > On 31.05.2017 15:08, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > >> diff --git a/platform/linux-generic/include/odp_packet_internal.h > >> b/platform/linux-generic/include/odp_packet_internal.h > >> index d0db7008..a480a748 100644 > >> --- a/platform/linux-generic/include/odp_packet_internal.h > >> +++ b/platform/linux-generic/include/odp_packet_internal.h > >> @@ -237,6 +237,12 @@ int packet_parse_common(packet_parser_t *pkt_hdr, > >> const uint8_t *ptr, > >> > >> int _odp_cls_parse(odp_packet_hdr_t *pkt_hdr, const uint8_t > *parseptr); > >> > >> +int _odp_packet_set_data(odp_packet_t pkt, uint32_t offset, > >> + uint8_t c, uint32_t len); > >> + > >> +int _odp_packet_cmp_data(odp_packet_t pkt, uint32_t offset, > >> + const void *s, uint32_t len); > >> + > > > > Since packet_internal.h is internal header and should not be visible to > application, _odp prefix is not needed. Most (all recent) functions in the > file do not have prefix. So, change to packet_set_data() and > packet_cmp_data() > > > These symbols still leak into static library poisoning global name. Thus > in my opinion we should limit non-static symbols to odp_ and _odp_ > namespaces. >
OK. Will you correct all other comments, including checkpatch warnings. It would be good to get these into the next release (wrapping up this week). -Petri
