This patch was blocking further progress on the scalable scheduler and had received multiple reviews on GitHub previously. I'm not sure why they didn't propagate to the log. We'll sort that out when Maxim gets back. The consensus yesterday at the close of the meeting (after you left, unfortunately) was to merge it to unblock the scheduler work and continue any additional restructuring needed as follow-on patches. This code represents no functional behavioral change, so it doesn't break anything. The disagreement seems purely stylistic, which can evolve with further patches.
There are many sections of code that can always be improved, and we cannot always get complete agreement on stylistic points. As a community project some flexibility in this area is expected to enable forward progress. Please feel free to post a follow-on patch if you feel strongly about some of these points, but everyone else seemed OK with moving forward this way. On Thu, Jun 8, 2017 at 2:53 AM, Savolainen, Petri (Nokia - FI/Espoo) <[email protected]> wrote: > So, this patch is now in the repo. I don't see *anybody* as a reviewer in the > git log. I did NACK it the qentry_from_int(queue_from_ext(handle)) clutter it > brings in the code base (for no real reason). That would have been an easy > fix. What did override our discipline of merging code ? > > -Petri > > >> -----Original Message----- >> From: lng-odp [mailto:[email protected]] On Behalf Of >> GitHub >> Sent: Wednesday, June 07, 2017 5:47 PM >> To: [email protected] >> Subject: [lng-odp] [Linaro/odp] 8b30e2: linux-generic: queue: modular >> queue interface >> >> Branch: refs/heads/api-next >> Home: https://github.com/Linaro/odp >> Commit: 8b30e228ba2c303b3c69ffa4fbb9f138d2523d9a >> >> https://github.com/Linaro/odp/commit/8b30e228ba2c303b3c69ffa4fbb9f138d2523 >> d9a >> Author: Honnappa Nagarahalli <[email protected]> >> Date: 2017-06-07 (Wed, 07 Jun 2017) >> >> Changed paths: >> M platform/linux-generic/Makefile.am >> M platform/linux-generic/include/odp_classification_datamodel.h >> M platform/linux-generic/include/odp_packet_io_queue.h >> A platform/linux-generic/include/odp_queue_if.h >> M platform/linux-generic/include/odp_queue_internal.h >> M platform/linux-generic/include/odp_schedule_if.h >> M platform/linux-generic/include/odp_traffic_mngr_internal.h >> M platform/linux-generic/odp_classification.c >> M platform/linux-generic/odp_init.c >> M platform/linux-generic/odp_packet_io.c >> M platform/linux-generic/odp_queue.c >> A platform/linux-generic/odp_queue_if.c >> M platform/linux-generic/odp_schedule.c >> M platform/linux-generic/odp_schedule_iquery.c >> M platform/linux-generic/odp_schedule_sp.c >> M platform/linux-generic/odp_traffic_mngr.c >> M platform/linux-generic/pktio/loop.c >> >> Log Message: >> ----------- >> linux-generic: queue: modular queue interface >> >> Created abstract queue type. Queue APIs and functions towards the >> internal components are converted into function pointers. >> >> Signed-off-by: Honnappa Nagarahalli <[email protected]> >> >
