On 2 August 2017 at 13:35, shally verma <[email protected]> wrote:
> Hi > > Based on discussion in yesterday's odp public call, I was trying to > exercise github pull request feature for patch submission. But running > into some doubts. > > -Should I create a pull request from a main odp.git repository like as > explained here https://help.github.com/articles/creating-a-pull- > request-from-a-fork/ > OR from my forked repository? > > Ex. I forked odp.git --> 1234sv/odp, where upstream is set to odp.git, > then both repos allow me to create a pull request to main odp.git repo > but I dont know which way is preferred over other. > > pull request to main repo. Link above is correct. > - In another email, Bill mentioned: > > "Every time a revision of a patch is submitted, increment the version. This > is done automatically if you use a GitHub pull request, " > > So, if I create a pull request where previous versions were > manual(like in case of comp spec) then we need to mention subject > [API-NEXT PATCH v5] on pull request edit? > yes, if you want to start with v5 then set this version in subject of pool request. > > - When email is sent to lng-odp after pull request, will it use github > account? if yes, do I need to subscribe that account to lng-odp? Say > my current github account is 1234sv and subscribed account is gmail > account, which of them will be used? > Email will be sent from ODP bot email account. Original author of patches will be inside patches. Actually you don't need to do anything with that. > > Any inputs would help! > > Thanks > Shally >
