From: Bill Fischofer [mailto:[email protected]] Sent: 03 August 2017 17:54 To: shally verma <[email protected]> Cc: Dmitry Eremin-Solenikov <[email protected]>; Challa, Mahipal <[email protected]>; lng-odp-forward <[email protected]>; Narayana, Prasad Athreya <[email protected]>; Verma, Shally <[email protected]>; Attunuru, Vamsi <[email protected]> Subject: Re: [lng-odp] Regarding github pull request
GitHub comments should be echoed to the ODP mailing list, so if you're subscribed you should see them. I too assumed so but it didn’t work this way. I did get PATCH email but not of review comments on it. I had to add my email ID to github Email settings. On Thu, Aug 3, 2017 at 12:40 AM, shally verma <[email protected]<mailto:[email protected]>> wrote: On Wed, Aug 2, 2017 at 10:04 PM, shally verma <[email protected]<mailto:[email protected]>> wrote: > On Wed, Aug 2, 2017 at 6:03 PM, Dmitry Eremin-Solenikov > <[email protected]<mailto:[email protected]>> > wrote: >> On 2 August 2017 at 15:18, shally verma >> <[email protected]<mailto:[email protected]>> wrote: >>> On Wed, Aug 2, 2017 at 4:37 PM, Maxim Uvarov >>> <[email protected]<mailto:[email protected]>> wrote: >>>> >>>> >>>> On 2 August 2017 at 14:05, Dmitry Eremin-Solenikov >>>> <[email protected]<mailto:[email protected]>> >>>> wrote: >>>>> >>>>> On 02/08/17 13:56, shally verma wrote: >>>>> > On Wed, Aug 2, 2017 at 4:15 PM, Maxim Uvarov >>>>> > <[email protected]<mailto:[email protected]>> >>>>> > wrote: >>>>> >> >>>>> >> >>>>> >> On 2 August 2017 at 13:35, shally verma >>>>> >> <[email protected]<mailto:[email protected]>> >>>>> >> wrote: >>>>> >>> >>>>> >>> Hi >>>>> >>> >>>>> >>> Based on discussion in yesterday's odp public call, I was trying to >>>>> >>> exercise github pull request feature for patch submission. But running >>>>> >>> into some doubts. >>>>> >>> >>>>> >>> -Should I create a pull request from a main odp.git repository like as >>>>> >>> explained here >>>>> >>> https://help.github.com/articles/creating-a-pull-request-from-a-fork/ >>>>> >>> OR from my forked repository? >>>>> >>> >>>>> >>> Ex. I forked odp.git --> 1234sv/odp, where upstream is set to odp.git, >>>>> >>> then both repos allow me to create a pull request to main odp.git repo >>>>> >>> but I dont know which way is preferred over other. >>>>> >>> >>>>> >> >>>>> >> pull request to main repo. Link above is correct. >>>>> >> >>>>> >> >>>>> >>> >>>>> >>> - In another email, Bill mentioned: >>>>> >>> >>>>> >>> "Every time a revision of a patch is submitted, increment the version. >>>>> >>> This >>>>> >>> is done automatically if you use a GitHub pull request, " >>>>> >>> >>>>> >>> So, if I create a pull request where previous versions were >>>>> >>> manual(like in case of comp spec) then we need to mention subject >>>>> >>> [API-NEXT PATCH v5] on pull request edit? >>>>> >> >>>>> >> >>>>> >> yes, if you want to start with v5 then set this version in subject of >>>>> >> pool >>>>> >> request. >>>>> >> >>>>> > I just created sample pull request with Subject [API-NEXT PATCH v5] >>>>> > but it changed to [PATCH API-NEXT v6] followed by my subject . So it >>>>> > look like: >>>>> > >>>>> > [PATCH API-NEXT v6] comp: compression spec. >>>>> >>>>> Version will autoincrement on each pull request update (initial >>>>> submission also counts). So, if you would like to send your PR as v5, >>>>> please change title now to v5. If you will push an update, title will >>>>> automatically be updated to v6 >>>>> >>>>> > Also I did not get any email for same. Something is pending? >>>>> >>>>> Yes. Maxim's script sends e-mails hourly. >>>>> >>>>> > How do we add other intended recipient to this patch ? outside of >>>>> > lng-odp list? >>>>> >>>>> Use Cc tags in individual patches. Maxim, will Cc tags work in cover >>>>> e-mail/PR description? >>>>> >>>> >>>> yes, they have to work. >>>> >>> An example would help here. Like if I do "git commit -m "Some message" >>> [email protected]<mailto:[email protected]> (i dont >>> see 'cc' as git commit >>> option')?? >>> Or what am I missing here? >> >> Just put Cc: somebody >> <[email protected]<mailto:[email protected]>> near your signed-off >> in >> the commit message. >> > Ok. But email is sent now. Any ways that we can add people now to > watch for further review comments on this? > Also. I can see review comments on login to github, but not in my mail box. Don't we get any notification into our mail box on every review input? Thanks Shally >>> >>> Thanks >>> Shally >>> >>>>> >>>>> > >>>>> > Thanks >>>>> > Shally >>>>> > >>>>> >>> >>>>> >>> >>>>> >>> - When email is sent to lng-odp after pull request, will it use github >>>>> >>> account? if yes, do I need to subscribe that account to lng-odp? Say >>>>> >>> my current github account is 1234sv and subscribed account is gmail >>>>> >>> account, which of them will be used? >>>>> >> >>>>> >> >>>>> >> Email will be sent from ODP bot email account. Original author of >>>>> >> patches >>>>> >> will be inside patches. Actually you don't need to do anything with >>>>> >> that. >>>>> >> >>>>> >> >>>>> >>> >>>>> >>> >>>>> >>> Any inputs would help! >>>>> >>> >>>>> >>> Thanks >>>>> >>> Shally >>>>> >> >>>>> >> >>>>> >>>>> >>>>> -- >>>>> With best wishes >>>>> Dmitry >>>> >>>> >> >> >> >> -- >> With best wishes >> Dmitry
